Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2900173004: WebUI: Only highlight scrollable divs (Closed)

Created:
3 years, 7 months ago by stevenjb
Modified:
3 years, 7 months ago
Reviewers:
scottchen, dschuyler
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebUI: Only highlight scrollable divs This CL: * Modifies the rule in shared_style_css for [scrollable] :focus to only include direct descendents of iron-list and to exclude .no-outline. * Removes [scrollable] .no-outline rule in settings_shared_css intended to do the same thing (but was not specific enough). * Removes some unused includes of CrScrollableBehavior. BUG=721723 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2900173004 Cr-Commit-Position: refs/heads/master@{#474180} Committed: https://chromium.googlesource.com/chromium/src/+/f0e5531d557726181f7004a6ad5fd4e7502787a9

Patch Set 1 #

Messages

Total messages: 9 (5 generated)
stevenjb
3 years, 7 months ago (2017-05-23 23:18:41 UTC) #3
dschuyler
lgtm
3 years, 7 months ago (2017-05-23 23:44:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900173004/1
3 years, 7 months ago (2017-05-24 00:14:13 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 06:06:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f0e5531d557726181f7004a6ad5f...

Powered by Google App Engine
This is Rietveld 408576698