cc : Remove transform nodes for scroll child

cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if didn't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now, render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2900153002
Cr-Commit-Position: refs/heads/master@{#474079}
Committed: https://chromium.googlesource.com/chromium/src/+/190125cd098bf1a71b7186b4278f6104aa0dbe6c

[jaydasika, 2017-05-23 18:52:21]

Description was changed from

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if din't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now. render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
==========

to

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if din't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now. render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jaydasika, 2017-05-23 18:53:39]

Description was changed from

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if din't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now. render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if din't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now, render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jaydasika, 2017-05-23 18:53:39]

jaydasika@chromium.org changed reviewers:
+ enne@chromium.org, weiliangc@chromium.org

[jaydasika, 2017-05-23 18:54:06]

PTAL

[enne (OOO), 2017-05-23 19:57:44]

Description was changed from

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if din't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now, render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if didn't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now, render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[enne (OOO), 2017-05-23 19:59:19]

This lgtm, but I'd like weiliangc to take a look too.

[jaydasika, 2017-05-23 20:33:42]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 20:35:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[weiliangc, 2017-05-23 21:59:45]

lgtm

[commit-bot: I haz the power, 2017-05-23 22:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 22:04:03]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2017-05-23 22:04:49]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2017-05-23 22:05:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 22:10:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495577089590580, "parent_rev":
"1a4c9a8ed39d4b4ce648487981b1b53da4c3c0ea", "commit_rev":
"190125cd098bf1a71b7186b4278f6104aa0dbe6c"}

[commit-bot: I haz the power, 2017-05-23 22:11:01]

Description was changed from

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if didn't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now, render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc : Remove transform nodes for scroll child

We create transform nodes for scroll child when it has a target
different from its scroll parent. We were doing this when we were
creating render surfaces on the main thread and had target_id on clip
and transform nodes because if didn't create a transform node, the
target_id would have been wrong for scroll child's subtree.

Now, render surfaces are created on compositor thread. We don't create
clip nodes for targets and don't have target ids on transform nodes, so
this is not required now.

BUG=723036
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2900153002
Cr-Commit-Position: refs/heads/master@{#474079}
Committed:
https://chromium.googlesource.com/chromium/src/+/190125cd098bf1a71b7186b4278f...
==========

[commit-bot: I haz the power, 2017-05-23 22:11:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/190125cd098bf1a71b7186b4278f...