Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2900143002: Update the OWNERS file for data* components (Closed)

Created:
3 years, 7 months ago by tbansal1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the OWNERS file for data* components Also, rm some of the old OWNERS BUG=679905 Review-Url: https://codereview.chromium.org/2900143002 Cr-Commit-Position: refs/heads/master@{#475635} Committed: https://chromium.googlesource.com/chromium/src/+/446b566d645551d8e592db6264691327d86d1424

Patch Set 1 : ps #

Total comments: 2

Patch Set 2 : bengr comment #

Patch Set 3 : rm deprecated OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M chrome/browser/data_saver/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/data_use_measurement/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/OWNERS View 2 chunks +2 lines, -1 line 0 comments Download
M components/data_usage/OWNERS View 1 chunk +3 lines, -1 line 0 comments Download
M components/data_use_measurement/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/previews/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/chrome_proxy/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/metrics/unittest_data/OWNERS View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 39 (21 generated)
tbansal1
ryansturm: ptal. Thanks.
3 years, 7 months ago (2017-05-23 18:30:58 UTC) #7
RyanSturm
lgtm
3 years, 7 months ago (2017-05-23 18:48:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900143002/40001
3 years, 7 months ago (2017-05-23 18:49:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/445166)
3 years, 7 months ago (2017-05-23 18:59:33 UTC) #12
tbansal1
bengr: ptal at tools/perf/metrics/unittest_data/OWNERS.
3 years, 7 months ago (2017-05-23 19:42:33 UTC) #14
tbansal1
bengr: ping.
3 years, 7 months ago (2017-05-25 17:49:09 UTC) #16
bengr
Other than the one suggestion, lgtm. https://codereview.chromium.org/2900143002/diff/40001/tools/perf/metrics/unittest_data/OWNERS File tools/perf/metrics/unittest_data/OWNERS (right): https://codereview.chromium.org/2900143002/diff/40001/tools/perf/metrics/unittest_data/OWNERS#newcode2 tools/perf/metrics/unittest_data/OWNERS:2: per-file *chrome_proxy*=marq@chromium.org Would ...
3 years, 7 months ago (2017-05-25 23:38:27 UTC) #17
tbansal1
https://codereview.chromium.org/2900143002/diff/40001/tools/perf/metrics/unittest_data/OWNERS File tools/perf/metrics/unittest_data/OWNERS (right): https://codereview.chromium.org/2900143002/diff/40001/tools/perf/metrics/unittest_data/OWNERS#newcode2 tools/perf/metrics/unittest_data/OWNERS:2: per-file *chrome_proxy*=marq@chromium.org On 2017/05/25 23:38:27, bengr wrote: > Would ...
3 years, 7 months ago (2017-05-26 01:27:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900143002/60001
3 years, 7 months ago (2017-05-26 01:28:03 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/448287)
3 years, 7 months ago (2017-05-26 01:39:45 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900143002/60001
3 years, 7 months ago (2017-05-26 01:42:09 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/448300)
3 years, 7 months ago (2017-05-26 01:53:43 UTC) #27
tbansal1
charliea: ptal at tools/perf/metrics/unittest_data/OWNERS. Thanks.
3 years, 7 months ago (2017-05-26 14:15:39 UTC) #30
tbansal1
charliea: ptal at tools/perf/metrics/unittest_data/OWNERS. Thanks.
3 years, 7 months ago (2017-05-26 14:15:39 UTC) #31
tbansal1
charliea: ping!!
3 years, 6 months ago (2017-05-30 16:13:50 UTC) #32
charliea (OOO until 10-5)
lgtm
3 years, 6 months ago (2017-05-30 18:02:22 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900143002/80001
3 years, 6 months ago (2017-05-30 18:03:53 UTC) #36
commit-bot: I haz the power
3 years, 6 months ago (2017-05-30 19:59:49 UTC) #39
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/446b566d645551d8e592db626469...

Powered by Google App Engine
This is Rietveld 408576698