Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2900123003: Intercept more OMA DRM download types (Closed)

Created:
3 years, 7 months ago by qinmin
Modified:
3 years, 7 months ago
CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Intercept more OMA DRM download types In addition to forward lock, some vendors support more OMA DRM types. These download will go through vendors' own DownloadManager implementation. And they are useless if downloaded through Chrome's network stack. This CL always pass those file types to Android DownloadManager. So vendors' DownloadManager impl will get a chance to handle them. BUG=725582 Review-Url: https://codereview.chromium.org/2900123003 Cr-Commit-Position: refs/heads/master@{#474540} Committed: https://chromium.googlesource.com/chromium/src/+/0966bd388358ed95921087f9096256ef15751f60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/OMADownloadHandler.java View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/android/download/intercept_download_resource_throttle.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
qinmin
PTAL
3 years, 7 months ago (2017-05-23 18:42:25 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-05-24 15:35:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900123003/1
3 years, 7 months ago (2017-05-24 22:21:37 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 03:12:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0966bd388358ed95921087f90962...

Powered by Google App Engine
This is Rietveld 408576698