Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2900083002: Fix the 2x NightLight icon (Closed)

Created:
3 years, 7 months ago by afakhry
Modified:
3 years, 7 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the 2x NightLight icon The previously generated skiafied 2x icon of the ON status of NightLight was misaligned with the OFF status icon. BUG=721952 TEST=Test on kevin, or on the emulator with --force-device-scale-factor=2. Make sure the ON and OFF icons are aligned. Review-Url: https://codereview.chromium.org/2900083002 Cr-Commit-Position: refs/heads/master@{#473974} Committed: https://chromium.googlesource.com/chromium/src/+/c288f5b4dc19ef6134a42db2b3f2e096f914a8aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M ash/resources/vector_icons/system_menu_night_light_on.icon View 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
afakhry
James. Please review this CL. Thank you.
3 years, 7 months ago (2017-05-23 16:38:24 UTC) #2
James Cook
rubber stamp LGTM
3 years, 7 months ago (2017-05-23 17:16:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2900083002/1
3 years, 7 months ago (2017-05-23 17:28:51 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 18:05:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c288f5b4dc19ef6134a42db2b3f2...

Powered by Google App Engine
This is Rietveld 408576698