Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 290003002: Remove OnMoreIOData() (Closed)

Created:
6 years, 7 months ago by no longer working on chromium
Modified:
6 years, 7 months ago
Reviewers:
dgreid, DaleCurtis
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, mikhal+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove OnMoreIOData(), which is not used any more. BUG=337096 TEST=bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271282

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed the comments. #

Patch Set 3 : proper upload and fixed the bot #

Patch Set 4 : fixed the media unittests on mac. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -255 lines) Patch
M content/browser/renderer_host/media/audio_sync_reader.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/android/audio_android_unittest.cc View 1 4 chunks +0 lines, -16 lines 0 comments Download
M media/audio/audio_io.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M media/audio/audio_output_controller.h View 4 chunks +4 lines, -8 lines 0 comments Download
M media/audio/audio_output_controller.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 3 chunks +1 line, -15 lines 0 comments Download
M media/audio/cras/cras_unified.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M media/audio/cras/cras_unified.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.h View 1 2 5 chunks +2 lines, -15 lines 0 comments Download
M media/audio/mac/audio_auhal_mac.cc View 1 2 13 chunks +28 lines, -120 lines 0 comments Download
M media/audio/mac/audio_auhal_mac_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/mock_audio_source_callback.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/simple_sources.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/simple_sources.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/audio/sounds/audio_stream_handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/audio/virtual_audio_input_stream_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
no longer working on chromium
Hi Dale, could you please review this CL? Dylan, I am removing the relevant unified ...
6 years, 7 months ago (2014-05-15 13:11:30 UTC) #1
dgreid
Seems OK to me. I wonder how clean it would be to revert the commit ...
6 years, 7 months ago (2014-05-15 17:37:56 UTC) #2
DaleCurtis
\o/ lgtm https://codereview.chromium.org/290003002/diff/1/media/audio/mac/audio_auhal_mac.cc File media/audio/mac/audio_auhal_mac.cc (right): https://codereview.chromium.org/290003002/diff/1/media/audio/mac/audio_auhal_mac.cc#newcode336 media/audio/mac/audio_auhal_mac.cc:336: bool AUHALStream::EnableIO() { Just inline this with ...
6 years, 7 months ago (2014-05-15 17:53:22 UTC) #3
no longer working on chromium
Thanks. Dylan, I updated the relevant comment and leave the decision to you on which ...
6 years, 7 months ago (2014-05-16 13:52:37 UTC) #4
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-16 13:52:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/290003002/20001
6 years, 7 months ago (2014-05-16 13:53:05 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 16:58:10 UTC) #7
no longer working on chromium
The CQ bit was unchecked by xians@chromium.org
6 years, 7 months ago (2014-05-16 17:08:31 UTC) #8
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-16 17:19:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/290003002/40001
6 years, 7 months ago (2014-05-16 17:20:54 UTC) #10
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-16 20:21:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/290003002/60001
6 years, 7 months ago (2014-05-16 20:23:04 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-17 11:43:43 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-17 12:42:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28150)
6 years, 7 months ago (2014-05-17 12:42:31 UTC) #15
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 7 months ago (2014-05-17 20:58:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/290003002/60001
6 years, 7 months ago (2014-05-17 20:58:38 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-05-18 13:53:06 UTC) #18
Message was sent while issue was closed. 
Change committed as 271282

Powered by Google App Engine
This is Rietveld 408576698