Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: media/audio/cras/cras_unified.h

Issue 290003002: Remove OnMoreIOData() (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: fixed the media unittests on mac. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_output_resampler.cc ('k') | media/audio/cras/cras_unified.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/cras/cras_unified.h
diff --git a/media/audio/cras/cras_unified.h b/media/audio/cras/cras_unified.h
index 2b29050d70e369b9ef1a71c636f655250350e303..db1d9feb648e3c0d2c606f9ab3dbe3474e8940a2 100644
--- a/media/audio/cras/cras_unified.h
+++ b/media/audio/cras/cras_unified.h
@@ -22,6 +22,9 @@ class AudioManagerCras;
// Implementation of AudioOuputStream for Chrome OS using the Chrome OS audio
// server.
+// TODO(dgreid): This class is used for only output, either remove all the
+// relevant input code and change the class to CrasOutputStream or merge
+// cras_input.cc into this unified implementation.
class MEDIA_EXPORT CrasUnifiedStream : public AudioOutputStream {
public:
// The ctor takes all the usual parameters, plus |manager| which is the
@@ -104,7 +107,7 @@ class MEDIA_EXPORT CrasUnifiedStream : public AudioOutputStream {
// Callback to get audio samples.
AudioSourceCallback* source_callback_;
- // Container for exchanging data with AudioSourceCallback::OnMoreIOData().
+ // Container for exchanging data with AudioSourceCallback::OnMoreData().
scoped_ptr<AudioBus> input_bus_;
scoped_ptr<AudioBus> output_bus_;
« no previous file with comments | « media/audio/audio_output_resampler.cc ('k') | media/audio/cras/cras_unified.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698