[logdog/common/types] custom JSON encoding to allow streamaddr to be zero.

[logdog/common/types] custom JSON encoding to allow streamaddr to be zero.

R=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2899993002
Committed: https://github.com/luci/luci-go/commit/2dc055c583df335f62536db98bcffd3afb739795

[iannucci, 2017-05-23 09:19:26]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:19:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 09:31:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:31:22]

Dry run: This issue passed the CQ dry run.

[iannucci, 2017-05-23 09:42:47]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:42:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 09:55:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:55:01]

Dry run: This issue passed the CQ dry run.

[dnj, 2017-05-23 15:28:19]

https://codereview.chromium.org/2899993002/diff/20001/logdog/common/types/str...
File logdog/common/types/streamaddr.go (right):

https://codereview.chromium.org/2899993002/diff/20001/logdog/common/types/str...
logdog/common/types/streamaddr.go:77: type jsonStreamAddr struct {
This is unfortunate. Are you opposed to using "omitempty" in all of the fields
and settling for an empty object instead of null?

addr: null
addr: {}

The latter isn't any less descriptive to me, and null will still unmarshal just
fine.

[iannucci, 2017-05-23 16:38:02]

On 2017/05/23 15:28:19, dnj wrote:
>
https://codereview.chromium.org/2899993002/diff/20001/logdog/common/types/str...
> File logdog/common/types/streamaddr.go (right):
> 
>
https://codereview.chromium.org/2899993002/diff/20001/logdog/common/types/str...
> logdog/common/types/streamaddr.go:77: type jsonStreamAddr struct {
> This is unfortunate. Are you opposed to using "omitempty" in all of the fields
> and settling for an empty object instead of null?
> 
> addr: null
> addr: {}
> 
> The latter isn't any less descriptive to me, and null will still unmarshal
just
> fine.

I think omitempty would actually be fine just by itself; Let me do that instead.

[iannucci, 2017-05-23 16:40:52]

The CQ bit was checked by iannucci@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 16:41:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-05-23 16:41:04]

done... duh :D

[commit-bot: I haz the power, 2017-05-23 16:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:49:15]

Dry run: This issue passed the CQ dry run.

[dnj, 2017-05-23 16:49:58]

lgtm

[iannucci, 2017-05-23 17:10:28]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-05-23 17:10:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 17:18:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495559428679680,
"parent_rev": "1bb3e6a70d32b62a064b30425b960bcd4b4260fd", "commit_rev":
"2dc055c583df335f62536db98bcffd3afb739795"}

[commit-bot: I haz the power, 2017-05-23 17:18:13]

Description was changed from

==========
[logdog/common/types] custom JSON encoding to allow streamaddr to be zero.

R=dnj@chromium.org
BUG=
==========

to

==========
[logdog/common/types] custom JSON encoding to allow streamaddr to be zero.

R=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2899993002
Committed:
https://github.com/luci/luci-go/commit/2dc055c583df335f62536db98bcffd3afb739795
==========

[commit-bot: I haz the power, 2017-05-23 17:18:14]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/2dc055c583df335f62536db98bcffd3afb739795