Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2899953002:
[logdog/common/types] add Valid method to StreamAddr. (Closed)
Description[logdog/common/types] add Validate method to StreamAddr.
R=dnj@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2899953002
Committed: https://github.com/luci/luci-go/commit/1bb3e6a70d32b62a064b30425b960bcd4b4260fd
Patch Set 1 #Patch Set 2 : make it Validate #Patch Set 3 : add IsZero #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by iannucci@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dnj@chromium.org
The CQ bit was checked by dnj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org Link to the patchset: https://codereview.chromium.org/2899953002/#ps40001 (title: "add IsZero")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dnj@chromium.org
The CQ bit was checked by iannucci@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [logdog/common/types] add Valid method to StreamAddr. R=dnj@chromium.org BUG= ========== to ========== [logdog/common/types] add Validate method to StreamAddr. R=dnj@chromium.org BUG= ==========
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495510143703020,
"parent_rev": "4363168106200329a674b3c6fd7a8bdb99ab0dd3", "commit_rev":
"1bb3e6a70d32b62a064b30425b960bcd4b4260fd"}
The CQ bit was unchecked by iannucci@chromium.org
Message was sent while issue was closed.
Description was changed from ========== [logdog/common/types] add Validate method to StreamAddr. R=dnj@chromium.org BUG= ========== to ========== [logdog/common/types] add Validate method to StreamAddr. R=dnj@chromium.org BUG= Review-Url: https://codereview.chromium.org/2899953002 Committed: https://github.com/luci/luci-go/commit/1bb3e6a70d32b62a064b30425b960bcd4b4260fd ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://github.com/luci/luci-go/commit/1bb3e6a70d32b62a064b30425b960bcd4b4260fd |
