Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Issue 2899943002: Gtk: Consider font dpi when calculating device scale factor (Closed)

3 years, 7 months ago by Tom Anderson
3 years, 7 months ago
chromium-reviews, oshima
Target Ref:


Gtk: Consider font dpi when calculating device scale factor Gtk2 did not have a global window scaling setting (so the only way to scale up widgets was with a custom theme). However, it did allow font scaling with gdk-xft-dpi (backed by XSetting Xft/DPI). Gtk3 adds (non-fractional) global window scaling with gdk-window-scaling-factor (XSetting Gdk/WindowScalingFactor). To ensure that fonts were not scaled up twice (once from gdk-window-scaling-factor and once from gdk-xft-dpi), a new setting was added in [1] that overrides gdk-xft-dpi: gdk-unscaled-dpi (XSetting Gdk/UnscaledDPI). gdk-xft-dpi was kept around for compatibility with apps like Chromium that still need it. When modifying these settings, an invariant should be maintained: gdk-xft-dpi = gtk-window-scaling-factor * gdk-unscaled-dpi. Chromium should have been able to keep using gdk-xft-dpi, but this invariant is violated when changing the settings using gnome-tweak-tool, where I have gdk-window-scaling-factor = 2, gdk-unscaled-dpi = 98304, and gdk-xft-dpi = 98304 (gdk-xft-dpi should be 196608). [2] changed Gtk builds to use the window scaling factor, which is incorrect because it did not consider font scaling, making fractional scaling impossible. This CL takes gdk-unscaled-dpi into the calculation as well, and continues to fallback on using gdk-xft-dpi if the other variables are unavailable, which can happen on Gtk2. [1] [2] BUG=723931, Review-Url: Cr-Commit-Position: refs/heads/master@{#473966} Committed:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M chrome/browser/ui/libgtkui/ View 2 chunks +23 lines, -9 lines 0 comments Download


Total messages: 13 (9 generated)
Tom Anderson
erg ptal
3 years, 7 months ago (2017-05-23 02:11:11 UTC) #4
Elliot Glaysher
3 years, 7 months ago (2017-05-23 17:21:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at:
3 years, 7 months ago (2017-05-23 17:40:19 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:46:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as

Powered by Google App Engine
This is Rietveld 408576698