Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

Issue 2899883002: Add a test for including all libraries from changed to the entry point. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/test/incremental_kernel_generator_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
diff --git a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
index 7761f31bb554c87ac46a83e389ee2928acd535e8..05e88e2a392f24d2618374ace8f9a5bb9c041adf 100644
--- a/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
+++ b/pkg/front_end/lib/src/incremental_kernel_generator_impl.dart
@@ -126,6 +126,9 @@ class IncrementalKernelGeneratorImpl implements IncrementalKernelGenerator {
}
// TODO(scheglov) Add libraries which import changed libraries.
+ // For now the corresponding test works because we use full library
+ // contents to compute signatures (not just API parts). So, every library
+ // that imports a changed one, is affected.
return new DeltaProgram(program);
});
« no previous file with comments | « no previous file | pkg/front_end/test/incremental_kernel_generator_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698