Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: pkg/front_end/lib/src/incremental_kernel_generator_impl.dart

Issue 2899883002: Add a test for including all libraries from changed to the entry point. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/front_end/test/incremental_kernel_generator_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:io'; 6 import 'dart:io';
7 7
8 import 'package:front_end/file_system.dart'; 8 import 'package:front_end/file_system.dart';
9 import 'package:front_end/incremental_kernel_generator.dart'; 9 import 'package:front_end/incremental_kernel_generator.dart';
10 import 'package:front_end/src/base/api_signature.dart'; 10 import 'package:front_end/src/base/api_signature.dart';
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 for (Library library in result.kernelLibraries) { 119 for (Library library in result.kernelLibraries) {
120 Uri uri = library.importUri; 120 Uri uri = library.importUri;
121 if (_latestSignature[uri] != result.signature) { 121 if (_latestSignature[uri] != result.signature) {
122 _latestSignature[uri] = result.signature; 122 _latestSignature[uri] = result.signature;
123 program.libraries.add(library); 123 program.libraries.add(library);
124 } 124 }
125 } 125 }
126 } 126 }
127 127
128 // TODO(scheglov) Add libraries which import changed libraries. 128 // TODO(scheglov) Add libraries which import changed libraries.
129 // For now the corresponding test works because we use full library
130 // contents to compute signatures (not just API parts). So, every library
131 // that imports a changed one, is affected.
129 132
130 return new DeltaProgram(program); 133 return new DeltaProgram(program);
131 }); 134 });
132 } 135 }
133 136
134 @override 137 @override
135 void invalidate(Uri uri) { 138 void invalidate(Uri uri) {
136 _invalidatedFiles.add(uri); 139 _invalidatedFiles.add(uri);
137 } 140 }
138 141
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 /// TODO(scheglov) Use API signatures. 302 /// TODO(scheglov) Use API signatures.
300 /// TODO(scheglov) Or use tree shaking and compute signatures of outlines. 303 /// TODO(scheglov) Or use tree shaking and compute signatures of outlines.
301 final String signature; 304 final String signature;
302 305
303 /// Kernel libraries for libraries in the [cycle]. Bodies of dependencies 306 /// Kernel libraries for libraries in the [cycle]. Bodies of dependencies
304 /// are not included, but but references to those dependencies are included. 307 /// are not included, but but references to those dependencies are included.
305 final List<Library> kernelLibraries; 308 final List<Library> kernelLibraries;
306 309
307 _LibraryCycleResult(this.cycle, this.signature, this.kernelLibraries); 310 _LibraryCycleResult(this.cycle, this.signature, this.kernelLibraries);
308 } 311 }
OLDNEW
« no previous file with comments | « no previous file | pkg/front_end/test/incremental_kernel_generator_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698