Updating D2D protocol to v1 to support separate sequence numbers.

Updating D2D protocol to v1 to support separate sequence numbers.

BUG=724710
Review-Url: https://codereview.chromium.org/2899863002
Cr-Commit-Position: refs/heads/master@{#473864}
Committed: https://chromium.googlesource.com/chromium/src/+/00555778f4fc32501162d851633180b1fe0cec9f

[sacomoto, 2017-05-22 22:55:42]

Description was changed from

==========
Updating D2D protocol to v1 to support separate sequence numbers.

BUG=724710
==========

to

==========
Updating D2D protocol to v1 to support separate sequence numbers.

BUG=724710
==========

[sacomoto, 2017-05-22 22:55:42]

sacomoto@chromium.org changed reviewers:
+ tengs@chromium.org

[sacomoto, 2017-05-22 22:55:54]

PTAL.

[Tim Song, 2017-05-22 23:18:24]

lgtm

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
File components/cryptauth/device_to_device_authenticator.h (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_authenticator.h:174: // The derived
symmetric key for the session.
nit: s/key/keys

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
File components/cryptauth/device_to_device_initiator_operations.cc (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_initiator_operations.cc:35: SessionKeys*
session_keys,
I would just take the initiator_encode_key() here.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_initiator_operations.cc:310: SessionKeys*
session_keys,
And down here, we can then make this argument "const SessionKeys&" instead, so
we don't have to keep a raw pointer around.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
File components/cryptauth/device_to_device_responder_operations.cc (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_responder_operations.cc:307: SessionKeys*
session_keys,
You should be able to use "const SessionKey&" instead.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/se...
File components/cryptauth/session_keys.h (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/se...
components/cryptauth/session_keys.h:14: class SessionKeys {
Add a brief class comment here.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/se...
components/cryptauth/session_keys.h:16: // Creates a WireMessage containing
|payload| for feature |feature|.
Remove comment.

[sacomoto, 2017-05-23 07:30:08]

The CQ bit was checked by sacomoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 07:30:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 08:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 08:41:38]

Dry run: This issue passed the CQ dry run.

[sacomoto, 2017-05-23 09:50:14]

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
File components/cryptauth/device_to_device_authenticator.h (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_authenticator.h:174: // The derived
symmetric key for the session.
On 2017/05/22 23:18:24, Tim Song wrote:
> nit: s/key/keys

Done.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
File components/cryptauth/device_to_device_initiator_operations.cc (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_initiator_operations.cc:35: SessionKeys*
session_keys,
On 2017/05/22 23:18:24, Tim Song wrote:
> I would just take the initiator_encode_key() here.

Done.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_initiator_operations.cc:310: SessionKeys*
session_keys,
On 2017/05/22 23:18:24, Tim Song wrote:
> And down here, we can then make this argument "const SessionKeys&" instead, so
> we don't have to keep a raw pointer around.

Done.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
File components/cryptauth/device_to_device_responder_operations.cc (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/de...
components/cryptauth/device_to_device_responder_operations.cc:307: SessionKeys*
session_keys,
On 2017/05/22 23:18:24, Tim Song wrote:
> You should be able to use "const SessionKey&" instead.

Done.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/se...
File components/cryptauth/session_keys.h (right):

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/se...
components/cryptauth/session_keys.h:14: class SessionKeys {
On 2017/05/22 23:18:24, Tim Song wrote:
> Add a brief class comment here.

Done.

https://codereview.chromium.org/2899863002/diff/20001/components/cryptauth/se...
components/cryptauth/session_keys.h:16: // Creates a WireMessage containing
|payload| for feature |feature|.
On 2017/05/22 23:18:24, Tim Song wrote:
> Remove comment.

Done.

[sacomoto, 2017-05-23 09:50:24]

The CQ bit was checked by sacomoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 09:50:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 11:15:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 11:15:52]

Dry run: This issue passed the CQ dry run.

[sacomoto, 2017-05-23 12:00:02]

The CQ bit was checked by sacomoto@chromium.org

[sacomoto, 2017-05-23 12:00:03]

The patchset sent to the CQ was uploaded after l-g-t-m from tengs@chromium.org
Link to the patchset: https://codereview.chromium.org/2899863002/#ps40001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-05-23 12:00:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 12:04:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495540802801210,
"parent_rev": "99e341b1997ed1ac37ea7c94b86c0c022559c38f", "commit_rev":
"00555778f4fc32501162d851633180b1fe0cec9f"}

[commit-bot: I haz the power, 2017-05-23 12:04:40]

Description was changed from

==========
Updating D2D protocol to v1 to support separate sequence numbers.

BUG=724710
==========

to

==========
Updating D2D protocol to v1 to support separate sequence numbers.

BUG=724710

Review-Url: https://codereview.chromium.org/2899863002
Cr-Commit-Position: refs/heads/master@{#473864}
Committed:
https://chromium.googlesource.com/chromium/src/+/00555778f4fc32501162d8516331...
==========

[commit-bot: I haz the power, 2017-05-23 12:04:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/00555778f4fc32501162d8516331...