Show the Translate bubble when the content web view is not focused

chrome/browser/ui/views/frame/browser_view.cc

Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 505532d439824ed66747a8df37029e7bba67a2fc..834239433175a9fbeb64957d272d4452b41834eb 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1159,6 +1159,13 @@ void BrowserView::ShowBookmarkAppBubble(
 void BrowserView::ShowTranslateBubble(content::WebContents* web_contents,
                                       translate::TranslateStep step,
                                       TranslateErrors::Type error_type) {
+  if (contents_web_view_->HasFocus() &&
+      !GetLocationBarView()->IsMouseHovered()) {

[sky, 2014/05/15 16:34:56]

Why the hovered check? What about users that are using the keyboard?

[hajimehoshi, 2014/05/16 03:49:50]

It's because when an input element is focused and the user is clicking the
Translate icon, the Translate bubble should be shown but the content web view
still has the focus even after clicking the icon.

Ideally, checking hovered is not needed but the reality is that the Translate
icon doesn't take focus and clicking the icon doesn't move the focus. As an
experiment, I changed the Translate icon to be able to take the focus, but the
situation didn't change.
Hmm, we need to consider the case when the keyboard shortcut or operation for
translation can be performed eventually...

AFAIK, the Translate feature doesn't have any keyboard shortcuts. Additionally,
the Translate icon doesn't take the focus, so it is impossible to launch the
Translate bubble from keyboard for now.

[sky, 2014/05/16 17:00:54]

Sorry, I still don't get it. Could you outline in more detail how we end up here
and why we care about focus? (Sorry)

+    content::RenderViewHost* rvh = web_contents->GetRenderViewHost();
+    if (rvh->IsFocusedElementEditable())
+      return;
+  }
+
   TranslateTabHelper* translate_tab_helper =
       TranslateTabHelper::FromWebContents(web_contents);
   LanguageState& language_state = translate_tab_helper->GetLanguageState();