Show the Translate bubble when the content web view is not focused

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 1141 matching lines @@
     const std::string& extension_id) {
   BookmarkAppBubbleView::ShowBubble(GetToolbarView(),
                                     browser_->profile(),
                                     web_app_info,
                                     extension_id);
 }
 
 void BrowserView::ShowTranslateBubble(content::WebContents* web_contents,
                                       translate::TranslateStep step,
                                       TranslateErrors::Type error_type) {
+  if (contents_web_view_->HasFocus() &&
+      !GetLocationBarView()->IsMouseHovered()) {

[sky, 2014/05/15 16:34:56]

Why the hovered check? What about users that are using the keyboard?

[hajimehoshi, 2014/05/16 03:49:50]

It's because when an input element is focused and the user is clicking the
Translate icon, the Translate bubble should be shown but the content web view
still has the focus even after clicking the icon.

Ideally, checking hovered is not needed but the reality is that the Translate
icon doesn't take focus and clicking the icon doesn't move the focus. As an
experiment, I changed the Translate icon to be able to take the focus, but the
situation didn't change.
Hmm, we need to consider the case when the keyboard shortcut or operation for
translation can be performed eventually...

AFAIK, the Translate feature doesn't have any keyboard shortcuts. Additionally,
the Translate icon doesn't take the focus, so it is impossible to launch the
Translate bubble from keyboard for now.

[sky, 2014/05/16 17:00:54]

Sorry, I still don't get it. Could you outline in more detail how we end up here
and why we care about focus? (Sorry)

+    content::RenderViewHost* rvh = web_contents->GetRenderViewHost();
+    if (rvh->IsFocusedElementEditable())
+      return;
+  }
+
   TranslateTabHelper* translate_tab_helper =
       TranslateTabHelper::FromWebContents(web_contents);
   LanguageState& language_state = translate_tab_helper->GetLanguageState();
   language_state.SetTranslateEnabled(true);
 
   TranslateBubbleView::ShowBubble(
       GetToolbarView()->GetTranslateBubbleAnchor(), web_contents, step,
       error_type);
 }
 
@@ skipping 1361 matching lines @@
       !GetLocationBar()->GetOmniboxView()->model()->popup_model()->IsOpen()) {
     gfx::Point icon_bottom(
         toolbar_->location_bar()->GetLocationBarAnchorPoint());
     ConvertPointToTarget(toolbar_->location_bar(), this, &icon_bottom);
     gfx::Point infobar_top(0, infobar_container_->GetVerticalOverlap(NULL));
     ConvertPointToTarget(infobar_container_, this, &infobar_top);
     top_arrow_height = infobar_top.y() - icon_bottom.y();
   }
   return top_arrow_height;
 }