Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5119)

Unified Diff: chrome/browser/translate/translate_tab_helper.cc

Issue 289983002: Show the Translate bubble when the content web view is not focused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_tab_helper.cc
diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc
index 4fab0728da9643b95e2327f9542744d388f105f9..6b2fd219dceb3040397cb1017cf468032f068692 100644
--- a/chrome/browser/translate/translate_tab_helper.cc
+++ b/chrome/browser/translate/translate_tab_helper.cc
@@ -514,10 +514,6 @@ void TranslateTabHelper::ShowBubble(translate::TranslateStep step,
if (web_contents() != browser->tab_strip_model()->GetActiveWebContents())
return;
- content::RenderViewHost* rvh = web_contents()->GetRenderViewHost();
- if (rvh->IsFocusedElementEditable())
- return;
-
// This ShowBubble function is also used for upating the existing bubble.
// However, with the bubble shown, any browser windows are NOT activated
// because the bubble takes the focus from the other widgets including the
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | chrome/browser/ui/views/frame/browser_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698