Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2899793002: Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't access DisplayItemClient::VisualRect() for cached display items. (patchset #3 id:40001 of https://codereview.chromium.org/2894093002/ ) Reason for revert: BUG=724920, 724263, 725041, 724936 Original issue's description: > Don't access DisplayItemClient::VisualRect() for cached display items. > > - Access DisplayItemClient::VisualRect() when a new DisplayItem is > created, and save it in the new DisplayItem. > - When a cached display item is copied, don't access DisplayItemClient:: > VisualRect() but fetch from the cached DisplayItem. > - Remove DisplayItemList::visual_rects_. > - Save original visual rects (LayoutRect) and apply GraphicsLayer offset > with EnclosingIntRect() when the display items are added into > WebDisplayItemList. > > Please see the bug for the reason. > > BUG=724263 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2894093002 > Cr-Commit-Position: refs/heads/master@{#473371} > Committed: https://chromium.googlesource.com/chromium/src/+/3c7f1c4ecd1421d074daa5a103ea3f895c1c8724 TBR=chrishtr@chromium.org,wkorman@chromium.org,pdr@chromium.org,michaelpg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724263 Review-Url: https://codereview.chromium.org/2899793002 Cr-Commit-Position: refs/heads/master@{#473640} Committed: https://chromium.googlesource.com/chromium/src/+/86c54d1018d43154254a9b479f43621bd8f6cad6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -197 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContentLayerDelegate.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ClipPathDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/CompositingDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 6 chunks +4 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.h View 2 chunks +16 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp View 2 chunks +30 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp View 1 chunk +74 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItemTest.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FilterDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/FloatClipDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ForeignLayerDisplayItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintChunkerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 2 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 9 chunks +28 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp View 12 chunks +27 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/ScrollDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/Transform3DDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/TransformDisplayItem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Xianzhu
Created Revert of Don't access DisplayItemClient::VisualRect() for cached display items.
3 years, 7 months ago (2017-05-22 16:57:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899793002/1
3 years, 7 months ago (2017-05-22 16:57:39 UTC) #3
michaelpg
revert lgtm
3 years, 7 months ago (2017-05-22 17:12:01 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 18:50:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86c54d1018d43154254a9b479f43...

Powered by Google App Engine
This is Rietveld 408576698