Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Unified Diff: components/ui_devtools/views/ui_devtools_css_agent.h

Issue 2899783002: Move DevTools out of ash and turn it to a component. (Closed)
Patch Set: NON_EXPORTED_BASE base class Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ui_devtools/views/ui_devtools_css_agent.h
diff --git a/ash/devtools/ash_devtools_css_agent.h b/components/ui_devtools/views/ui_devtools_css_agent.h
similarity index 72%
rename from ash/devtools/ash_devtools_css_agent.h
rename to components/ui_devtools/views/ui_devtools_css_agent.h
index 9225475f65636cb691b66a7624c5736a1585cceb..969bf34cb9735a41d217ca5ad62dfe396161da05 100644
--- a/ash/devtools/ash_devtools_css_agent.h
+++ b/components/ui_devtools/views/ui_devtools_css_agent.h
@@ -2,24 +2,23 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef ASH_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
-#define ASH_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
+#ifndef COMPONENTS_UI_DEVTOOLS_VIEWS_UI_DEVTOOLS_CSS_AGENT_H_
+#define COMPONENTS_UI_DEVTOOLS_VIEWS_UI_DEVTOOLS_CSS_AGENT_H_
-#include "ash/ash_export.h"
-#include "ash/devtools/ash_devtools_dom_agent.h"
#include "base/macros.h"
#include "components/ui_devtools/CSS.h"
+#include "components/ui_devtools/views/ui_devtools_dom_agent.h"
-namespace ash {
+namespace ui {
namespace devtools {
-class ASH_EXPORT AshDevToolsCSSAgent
+class UIDevToolsCSSAgent
: public NON_EXPORTED_BASE(ui::devtools::UiDevToolsBaseAgent<
sadrul 2017/06/14 03:25:57 You should no longer need NON_EXPORTED_BASE here.
thanhph 2017/06/14 15:26:37 Done.
ui::devtools::protocol::CSS::Metainfo>),
- public AshDevToolsDOMAgentObserver {
+ public UIDevToolsDOMAgentObserver {
public:
- explicit AshDevToolsCSSAgent(AshDevToolsDOMAgent* dom_agent);
- ~AshDevToolsCSSAgent() override;
+ explicit UIDevToolsCSSAgent(UIDevToolsDOMAgent* dom_agent);
+ ~UIDevToolsCSSAgent() override;
// CSS::Backend:
ui::devtools::protocol::Response enable() override;
@@ -35,7 +34,7 @@ class ASH_EXPORT AshDevToolsCSSAgent
ui::devtools::protocol::Array<ui::devtools::protocol::CSS::CSSStyle>>*
result) override;
- // AshDevToolsDOMAgentObserver:
+ // UIDevToolsDOMAgentObserver:
void OnNodeBoundsChanged(int node_id) override;
private:
@@ -46,12 +45,12 @@ class ASH_EXPORT AshDevToolsCSSAgent
bool SetPropertiesForNodeId(int node_id,
const gfx::Rect& bounds,
bool visible);
- AshDevToolsDOMAgent* dom_agent_;
+ UIDevToolsDOMAgent* dom_agent_;
- DISALLOW_COPY_AND_ASSIGN(AshDevToolsCSSAgent);
+ DISALLOW_COPY_AND_ASSIGN(UIDevToolsCSSAgent);
};
} // namespace devtools
-} // namespace ash
+} // namespace ui
-#endif // ASH_DEVTOOLS_ASH_DEVTOOLS_CSS_AGENT_H_
+#endif // COMPONENTS_UI_DEVTOOLS_VIEWS_UI_DEVTOOLS_CSS_AGENT_H_

Powered by Google App Engine
This is Rietveld 408576698