Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)
Patch Set: Addressed nit Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
index 1d486538241f036de52851293b7db061fb9c6852..ab5ec216fdea6fddde89eba4b84ae83d05a0888a 100644
--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
@@ -49,13 +49,13 @@ void JavaScriptDialogHelper::RunJavaScriptDialog(
const DialogClosedCallback& callback,
bool* did_suppress_message) {
base::DictionaryValue request_info;
- request_info.Set(webview::kDefaultPromptText,
- new base::Value(base::UTF16ToUTF8(default_prompt_text)));
- request_info.Set(webview::kMessageText,
- new base::Value(base::UTF16ToUTF8(message_text)));
- request_info.Set(webview::kMessageType,
- new base::Value(JavaScriptDialogTypeToString(dialog_type)));
- request_info.Set(guest_view::kUrl, new base::Value(origin_url.spec()));
+ request_info.SetString(webview::kDefaultPromptText,
+ base::UTF16ToUTF8(default_prompt_text));
+ request_info.SetString(webview::kMessageText,
+ base::UTF16ToUTF8(message_text));
+ request_info.SetString(webview::kMessageType,
+ JavaScriptDialogTypeToString(dialog_type));
+ request_info.SetString(guest_view::kUrl, origin_url.spec());
WebViewPermissionHelper* web_view_permission_helper =
WebViewPermissionHelper::FromWebContents(web_contents);
web_view_permission_helper->RequestPermission(

Powered by Google App Engine
This is Rietveld 408576698