extensions/browser/guest_view/app_view/app_view_guest.cc - Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/app_view/app_view_guest.cc

Issue 2899743002: Remove raw base::DictionaryValue::Set in //extensions (Closed)

Patch Set: Addressed nit Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/app_view/app_view_guest.cc

diff --git a/extensions/browser/guest_view/app_view/app_view_guest.cc b/extensions/browser/guest_view/app_view/app_view_guest.cc

index d153e31dc95807879cdc2e3dc0be6daa1b752e6e..0db38506189df14da9c3d09802859584d94eda65 100644

--- a/extensions/browser/guest_view/app_view/app_view_guest.cc

+++ b/extensions/browser/guest_view/app_view/app_view_guest.cc

@@ -268,7 +268,7 @@ void AppViewGuest::LaunchAppAndFireEvent(

new base::DictionaryValue());

embed_request->SetInteger(appview::kGuestInstanceID, guest_instance_id());

embed_request->SetString(appview::kEmbedderID, owner_host());

- embed_request->Set(appview::kData, data.release());

+ embed_request->Set(appview::kData, std::move(data));

AppRuntimeEventRouter::DispatchOnEmbedRequestedEvent(

browser_context(), std::move(embed_request), extension_host->extension());

}