Remove raw base::DictionaryValue::Set in //extensions

extensions/browser/guest_view/web_view/web_view_find_helper.cc

Index: extensions/browser/guest_view/web_view/web_view_find_helper.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_find_helper.cc b/extensions/browser/guest_view/web_view/web_view_find_helper.cc
index dc4c5828151960d384fca0d520f5406816ec9fcf..0ef4e96a2711fb3ba417c32253f569a4b5a86053 100644
--- a/extensions/browser/guest_view/web_view/web_view_find_helper.cc
+++ b/extensions/browser/guest_view/web_view/web_view_find_helper.cc
@@ -221,7 +221,8 @@ void WebViewFindHelper::FindResults::PrepareResults(
   rect.SetInteger(webview::kFindRectTop, selection_rect_.y());
   rect.SetInteger(webview::kFindRectWidth, selection_rect_.width());
   rect.SetInteger(webview::kFindRectHeight, selection_rect_.height());
-  results->Set(webview::kFindSelectionRect, rect.DeepCopy());
+  results->Set(webview::kFindSelectionRect,
+               base::MakeUnique<base::Value>(rect));

[Devlin, 2017/06/02 15:38:48]

This was wrong before, but let's fix it :)
|rect| should be a std::unique_ptr<> so that we can just move it in, rather than
doing this copy.

[vabr (Chromium), 2017/06/03 11:14:52]

My suggestion is to keep |rect| just a DictionaryValue and move it. base::Value
has a move constructor, so this should still be efficient, and the code will be
ready for the future form of the base::Value API, which is to be used without
heap allocation if possible.

[Devlin, 2017/06/05 13:27:33]

That's fine, too - either way, we avoid the copy, which is what my concern is.

[jdoerrie, 2017/06/06 12:40:23]

I added a call to std::move to avoid the copy here. DictionaryValues currently
still store unique_ptrs under the hood, which is why the heap allocation can't
be avoided yet.

 }
 
 WebViewFindHelper::FindUpdateEvent::FindUpdateEvent(