Remove raw base::DictionaryValue::Set in //extensions

extensions/browser/guest_view/web_view/web_view_find_helper.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/guest_view/web_view/web_view_find_helper.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "components/guest_view/browser/guest_view_event.h"
@@ skipping 203 matching lines @@
 
 void WebViewFindHelper::FindResults::PrepareResults(
     base::DictionaryValue* results) {
   results->SetInteger(webview::kFindNumberOfMatches, number_of_matches_);
   results->SetInteger(webview::kFindActiveMatchOrdinal, active_match_ordinal_);
   base::DictionaryValue rect;
   rect.SetInteger(webview::kFindRectLeft, selection_rect_.x());
   rect.SetInteger(webview::kFindRectTop, selection_rect_.y());
   rect.SetInteger(webview::kFindRectWidth, selection_rect_.width());
   rect.SetInteger(webview::kFindRectHeight, selection_rect_.height());
-  results->Set(webview::kFindSelectionRect, rect.DeepCopy());
+  results->Set(webview::kFindSelectionRect,
+               base::MakeUnique<base::Value>(rect));

[Devlin, 2017/06/02 15:38:48]

This was wrong before, but let's fix it :)
|rect| should be a std::unique_ptr<> so that we can just move it in, rather than
doing this copy.

[vabr (Chromium), 2017/06/03 11:14:52]

My suggestion is to keep |rect| just a DictionaryValue and move it. base::Value
has a move constructor, so this should still be efficient, and the code will be
ready for the future form of the base::Value API, which is to be used without
heap allocation if possible.

[Devlin, 2017/06/05 13:27:33]

That's fine, too - either way, we avoid the copy, which is what my concern is.

[jdoerrie, 2017/06/06 12:40:23]

I added a call to std::move to avoid the copy here. DictionaryValues currently
still store unique_ptrs under the hood, which is why the heap allocation can't
be avoided yet.

 }
 
 WebViewFindHelper::FindUpdateEvent::FindUpdateEvent(
     const base::string16& search_text)
     : search_text_(search_text) {
 }
 
 WebViewFindHelper::FindUpdateEvent::~FindUpdateEvent() {
 }
 
@@ skipping 47 matching lines @@
   results.SetBoolean(webview::kFindCanceled, canceled);
 
   // Call the callback.
   find_function_->SetResult(results.CreateDeepCopy());
   find_function_->SendResponse(true);
 }
 
 WebViewFindHelper::FindInfo::~FindInfo() {}
 
 }  // namespace extensions