Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2899723003: Remove raw base::DictionaryValue::Set in //net (Closed)

Created:
3 years, 7 months ago by jdoerrie
Modified:
3 years, 6 months ago
Reviewers:
vabr (Chromium), agl
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, eroman, mmenke, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove raw DictionaryValue::Set in //net This change removes the deprecated raw pointer version of base::DictionaryValue::Set in //net and replaces it with the unique pointer version or other convenience functions where appropriate. BUG=646113, 581865 Review-Url: https://codereview.chromium.org/2899723003 Cr-Commit-Position: refs/heads/master@{#477614} Committed: https://chromium.googlesource.com/chromium/src/+/4eea70fa2aa13869e8599bc1cd511a0e05146af4

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -58 lines) Patch
M net/dns/dns_config_service.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M net/http/http_request_headers.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_response_headers.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M net/http/transport_security_persister.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M net/log/net_log_util.cc View 1 2 11 chunks +21 lines, -16 lines 0 comments Download
M net/proxy/proxy_config.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_connection_logger.cc View 5 chunks +18 lines, -18 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/test/spawned_test_server/base_test_server.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (17 generated)
jdoerrie
vabr@chromium.org: Please review the whole CL in detail. agl@chromium.org: Please spot-check and rubber-stamp.
3 years, 6 months ago (2017-06-02 13:45:08 UTC) #13
vabr (Chromium)
LGTM, great to see the raw pointers gone! Cheers, Vaclav
3 years, 6 months ago (2017-06-03 10:57:59 UTC) #16
jdoerrie
Thanks, Vaclav! Friendly ping at agl@.
3 years, 6 months ago (2017-06-06 12:25:13 UTC) #17
agl
lgtm
3 years, 6 months ago (2017-06-06 16:27:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899723003/40001
3 years, 6 months ago (2017-06-07 10:34:39 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 11:58:47 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4eea70fa2aa13869e8599bc1cd51...

Powered by Google App Engine
This is Rietveld 408576698