Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2899693003: Fix crash with generalized function types in type tests. (Closed)

Created:
3 years, 7 months ago by ahe
Modified:
3 years, 7 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -4 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 3 chunks +5 lines, -3 lines 0 comments Download
A pkg/front_end/testcases/function_type_is_check.dart View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/function_type_is_check.dart.direct.expect View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/function_type_is_check.dart.outline.expect View 1 chunk +7 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/function_type_is_check.dart.strong.expect View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/tool/fasta View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
3 years, 7 months ago (2017-05-22 11:24:12 UTC) #2
Johnni Winther
lgtm
3 years, 7 months ago (2017-05-22 11:47:18 UTC) #3
ahe
3 years, 7 months ago (2017-05-22 12:53:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de7edcde7474d1f3d4598d686c626c3e3b0f554a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698