Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: pkg/front_end/tool/fasta

Issue 2899693003: Fix crash with generalized function types in type tests. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/testcases/function_type_is_check.dart.strong.expect ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/tool/fasta
diff --git a/pkg/front_end/tool/fasta b/pkg/front_end/tool/fasta
index 45a5f3d1b0b5492986befd56579b85baf0a959d7..4d269f33f9fd51f5805a6f07b2780415fd2f71f1 100755
--- a/pkg/front_end/tool/fasta
+++ b/pkg/front_end/tool/fasta
@@ -20,6 +20,8 @@ function stop {
exit 1
}
+DART_CONFIGURATION=${DART_CONFIGURATION:-ReleaseX64}
+
case "${1//_/-}" in
abcompile) SCRIPT="${TOOL_DIR}/abcompile.dart";;
analyzer-compile) SCRIPT="${TOOL_DIR}/analyzer_compile.dart";;
@@ -49,7 +51,11 @@ case "${1//_/-}" in
;;
kernel-service)
shift
+ PATCHED_SDK_DIR=$(
+ ls -d {xcodebuild,out}/${DART_CONFIGURATION}/patched_sdk 2>/dev/null \
+ | head -1)
exec "${DART_VM}" -c -DDFE_VERBOSE=true \
+ --platform=${PATCHED_SDK_DIR}/platform.dill \
--dfe="${REPO_DIR}/utils/kernel-service/kernel-service.dart" "$@"
;;
testing)
@@ -64,4 +70,4 @@ esac
shift
-DART_CONFIGURATION=${DART_CONFIGURATION:-ReleaseX64} exec "${DART_VM}" -c "${SCRIPT}" "$@"
+exec "${DART_VM}" -c "${SCRIPT}" "$@"
« no previous file with comments | « pkg/front_end/testcases/function_type_is_check.dart.strong.expect ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698