Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2899673002: Network traffic annotation added to DataReductionProxy unittests. (Closed)

Created:
3 years, 7 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
Reviewers:
Raj, tbansal1
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to DataReductionProxy unittests. Network traffic annotation is added to network requests of: components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc BUG=656607 Review-Url: https://codereview.chromium.org/2899673002 Cr-Commit-Position: refs/heads/master@{#473612} Committed: https://chromium.googlesource.com/chromium/src/+/29a6403a0f484e7e33b63df2d738f0568559e180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 6 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Ramin Halavati
Raj, I've added a few more test annotation tags to data reduction proxy unittests, please ...
3 years, 7 months ago (2017-05-22 08:17:37 UTC) #6
tbansal1
lgtm raj is probably OOO, so changing the reviewer to myself.
3 years, 7 months ago (2017-05-22 17:26:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899673002/1
3 years, 7 months ago (2017-05-22 17:27:14 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 17:33:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/29a6403a0f484e7e33b63df2d738...

Powered by Google App Engine
This is Rietveld 408576698