Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2899613002: DOM: Fix an issue of reversed MutationRecoards. (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM: Fix an issue of reversed MutationRecoards. In appendChild, insertBefore, and replaceChild, ChildListMutationScope should be destructed before calling notifications which can execute author scripts. This CL splits InsertNodeVector() into two parts; one should be wrapped with ChildListMutationScope, and another should not. The new behavior matches to the DOM standard, Firefox, and Edge. BUG=711568 Review-Url: https://codereview.chromium.org/2899613002 Cr-Commit-Position: refs/heads/master@{#473512} Committed: https://chromium.googlesource.com/chromium/src/+/5a3def7f350a35e7e481714f0d3851c9434cdeec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -50 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/dom/nodes/MutationObserver-document-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.h View 1 chunk +11 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 5 chunks +66 lines, -41 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
hayato@, would you review this please?
3 years, 7 months ago (2017-05-22 03:05:26 UTC) #6
hayato
lgtm
3 years, 7 months ago (2017-05-22 05:11:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899613002/1
3 years, 7 months ago (2017-05-22 05:57:39 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 06:02:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a3def7f350a35e7e481714f0d38...

Powered by Google App Engine
This is Rietveld 408576698