Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2899583002: issue2882533003_180001.diff.txt (patch set 6)

Created:
3 years, 7 months ago by tapted
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, tfarina, lgarron+watch_chromium.org, raymes+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

issue2882533003_180001.diff.txt (patch set 6) BUG=715863

Patch Set 1 #

Patch Set 2 : DIFF #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -189 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 4 chunks +0 lines, -43 lines 0 comments Download
A chrome/browser/ui/cocoa/browser_dialogs_views_mac.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A + chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc View 1 6 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 4 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bubble_anchor_helper_views.h View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bubble_anchor_helper_views.mm View 4 chunks +34 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm View 1 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_dialogs_views_mac.cc View 1 1 chunk +0 lines, -112 lines 0 comments Download
M chrome/browser/ui/views/page_info/page_info_bubble_view.h View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/page_info/page_info_bubble_view.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (11 generated)
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-21 03:49:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899583002/20001
3 years, 7 months ago (2017-05-21 03:49:53 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-21 03:57:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899583002/40001
3 years, 7 months ago (2017-05-21 03:57:35 UTC) #4
tapted
Patchset #2 (id:20001) has been deleted
3 years, 7 months ago (2017-05-21 04:35:26 UTC) #5
tapted
The CQ bit was unchecked by tapted@chromium.org
3 years, 7 months ago (2017-05-21 04:35:31 UTC) #6
tapted
The CQ bit was checked by tapted@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-21 08:01:31 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899583002/60001
3 years, 7 months ago (2017-05-21 08:01:44 UTC) #8
tapted
Patchset #2 (id:40001) has been deleted
3 years, 7 months ago (2017-05-21 08:05:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-21 09:55:26 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 09:55:27 UTC) #11
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698