Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2899533002: [MD settings] move <dialog> out of content (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 31e1b3a19b497c45abe95cfcfa8d56494161c561..3cd4cd78fcbf7ce99aa4ba29e21a13019e856e5d 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -44,6 +44,24 @@
on-close="onDialogClosed_">
</settings-clear-browsing-data-dialog>
</template>
+ <template id="doNotTrackDialogIf" is="dom-if"
+ if="[[showDoNotTrackDialog_]]" notify-dom-change>
+ <dialog is="cr-dialog" id="confirmDoNotTrackDialog"
+ close-text="$i18n{close}" on-cancel="onDoNotTrackDialogCancel_">
+ <div class="title">$i18n{doNotTrackDialogTitle}</div>
+ <div class="body">$i18nRaw{doNotTrackDialogMessage}</div>
+ <div class="button-container">
+ <paper-button class="cancel-button"
+ on-tap="onDoNotTrackDialogCancel_">
+ $i18n{cancel}
+ </paper-button>
+ <paper-button class="action-button"
+ on-tap="onDoNotTrackDialogConfirm_">
+ $i18n{confirm}
+ </paper-button>
+ </div>
+ </dialog>
+ </template>
dschuyler 2017/05/19 23:46:30 This should be moved with no other changes.
<settings-animated-pages id="pages" section="privacy"
focus-config="[[focusConfig_]]">
<neon-animatable route-path="default">
@@ -113,24 +131,6 @@
</if><!-- not chromeos -->
</if><!-- _google_chrome -->
<div class="settings-box">
- <template id="doNotTrackDialogIf" is="dom-if"
- if="[[showDoNotTrackDialog_]]" notify-dom-change>
- <dialog is="cr-dialog" id="confirmDoNotTrackDialog"
- close-text="$i18n{close}" on-cancel="onDoNotTrackDialogCancel_">
- <div class="title">$i18n{doNotTrackDialogTitle}</div>
- <div class="body">$i18nRaw{doNotTrackDialogMessage}</div>
- <div class="button-container">
- <paper-button class="cancel-button"
- on-tap="onDoNotTrackDialogCancel_">
- $i18n{cancel}
- </paper-button>
- <paper-button class="action-button"
dschuyler 2017/05/19 23:46:30 This was picking up CSS from .settings-box paper-
- on-tap="onDoNotTrackDialogConfirm_">
- $i18n{confirm}
- </paper-button>
- </div>
- </dialog>
- </template>
<settings-toggle-button id="doNotTrack" class="start"
pref="{{prefs.enable_do_not_track}}" label="$i18n{doNotTrack}"
on-settings-boolean-control-change="onDoNotTrackChange_"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698