[MD settings] move <dialog> out of content

chrome/browser/resources/settings/privacy_page/privacy_page.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 
 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
 <link rel="import" href="chrome://resources/cr_elements/policy/cr_policy_vars_css.html">
 <link rel="import" href="chrome://resources/html/assert.html">
 <link rel="import" href="chrome://resources/html/cr/ui/focus_without_ink.html">
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
@@ skipping 26 matching lines @@
 
 <dom-module id="settings-privacy-page">
   <template>
     <style include="settings-shared">
     </style>
     <template is="dom-if" if="[[showClearBrowsingDataDialog_]]" restamp>
       <settings-clear-browsing-data-dialog prefs="{{prefs}}"
           on-close="onDialogClosed_">
       </settings-clear-browsing-data-dialog>
     </template>
+    <template id="doNotTrackDialogIf" is="dom-if"
+        if="[[showDoNotTrackDialog_]]" notify-dom-change>
+      <dialog is="cr-dialog" id="confirmDoNotTrackDialog"
+          close-text="$i18n{close}" on-cancel="onDoNotTrackDialogCancel_">
+        <div class="title">$i18n{doNotTrackDialogTitle}</div>
+        <div class="body">$i18nRaw{doNotTrackDialogMessage}</div>
+        <div class="button-container">
+          <paper-button class="cancel-button"
+              on-tap="onDoNotTrackDialogCancel_">
+            $i18n{cancel}
+          </paper-button>
+          <paper-button class="action-button"
+              on-tap="onDoNotTrackDialogConfirm_">
+            $i18n{confirm}
+          </paper-button>
+        </div>
+      </dialog>
+    </template>

[dschuyler, 2017/05/19 23:46:30]

This should be moved with no other changes.

     <settings-animated-pages id="pages" section="privacy"
         focus-config="[[focusConfig_]]">
       <neon-animatable route-path="default">
         <div class="settings-box first">
           <p class="privacy-explanation">$i18nRaw{improveBrowsingExperience}</p>
         </div>
         <div class="settings-box">
           <settings-toggle-button class="start"
               pref="{{prefs.alternate_error_pages.enabled}}"
               label="$i18n{linkDoctorPref}">
@@ skipping 49 matching lines @@
               <paper-button on-tap="onRestartTap_" id="restart"
                   class="more-actions">
                 $i18n{restart}
               </paper-button>
             </template>
           </settings-toggle-button>
         </div>
 </if><!-- not chromeos -->
 </if><!-- _google_chrome -->
         <div class="settings-box">
-          <template id="doNotTrackDialogIf" is="dom-if"
-              if="[[showDoNotTrackDialog_]]" notify-dom-change>
-            <dialog is="cr-dialog" id="confirmDoNotTrackDialog"
-                close-text="$i18n{close}" on-cancel="onDoNotTrackDialogCancel_">
-              <div class="title">$i18n{doNotTrackDialogTitle}</div>
-              <div class="body">$i18nRaw{doNotTrackDialogMessage}</div>
-              <div class="button-container">
-                <paper-button class="cancel-button"
-                    on-tap="onDoNotTrackDialogCancel_">
-                  $i18n{cancel}
-                </paper-button>
-                <paper-button class="action-button"

[dschuyler, 2017/05/19 23:46:30]

This was picking up CSS from

.settings-box paper-button

Because it was actually within a settings-box.

-                    on-tap="onDoNotTrackDialogConfirm_">
-                  $i18n{confirm}
-                </paper-button>
-              </div>
-            </dialog>
-          </template>
           <settings-toggle-button id="doNotTrack" class="start"
               pref="{{prefs.enable_do_not_track}}" label="$i18n{doNotTrack}"
               on-settings-boolean-control-change="onDoNotTrackChange_"
               no-set-pref>
           </settings-toggle-button>
         </div>
 <if expr="chromeos">
         <div class="settings-box">
           <settings-toggle-button class="start"
               pref="{{prefs.cros.device.attestation_for_content_protection_enabled}}"
@@ skipping 352 matching lines @@
                 category="{{ContentSettingsTypes.PROTECTED_CONTENT}}">
             </category-setting-exceptions>
           </template>
 </if>
         </settings-subpage>
       </template>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>
 </dom-module>