Pass parsed network quality estimator params when constructing NQE

Pass parsed network quality estimator params when constructing NQE

This CL changes the way how Network Quality Estimator (NQE) is 
constructed. Currently, NQE configuration parameters are passed as
key-value pair by Chrome/Cronet in the NQE's constructor.

This CL requires Chrome/Cronet to parse the config params themselves,
store them in a class, and pass an instance of that class in the 
constructor of NQE.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=638308
Review-Url: https://codereview.chromium.org/2899453002
Cr-Commit-Position: refs/heads/master@{#477896}
Committed: https://chromium.googlesource.com/chromium/src/+/4a4305a5f603f83ce7eafad9866565af013815c5

[tbansal1, 2017-05-19 18:32:08]

Description was changed from

==========
NQE params


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
NQE params


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=
==========

[tbansal1, 2017-05-19 18:32:33]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:34:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-05-19 18:41:19]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2017-05-19 18:41:24]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-05-19 18:42:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-05-19 18:48:45]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:49:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 19:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 19:04:16]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tbansal1, 2017-05-19 19:37:01]

Patchset #1 (id:20001) has been deleted

[tbansal1, 2017-05-19 19:37:34]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 19:38:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-05-19 19:38:58]

Patchset #1 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-05-19 19:50:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 19:50:15]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[tbansal1, 2017-05-19 19:55:26]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 19:56:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-05-19 19:58:19]

Description was changed from

==========
NQE params


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=
==========

to

==========
Pass parsed network quality estimator params when constructing NQE

This CL changes the way how Network Quality Estimator (NQE) is 
constructed. Currently, NQE configuration parameters are passed as
key-value pair by Chrome/Cronet in the NQE's constructor.

This CL requires Chrome/Cronet to parse the config params themselves,
store them in a class, and pass an instance of that class in the 
constructor of NQE.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=638308
==========

[tbansal1, 2017-05-19 19:58:28]

Patchset #1 (id:60001) has been deleted

[tbansal1, 2017-05-19 19:59:55]

tbansal@chromium.org changed reviewers:
+ mmenke@chromium.org

[tbansal1, 2017-05-19 19:59:56]

mmenke: ptal at io_thread*, and let me know if this is the
right way for configuring //net objects for servicification.

If that looks good, PTAL at  
chrome/browser/android/net/* too. Thanks.

[commit-bot: I haz the power, 2017-05-19 20:27:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 20:27:03]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tbansal1, 2017-05-19 21:01:00]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 21:02:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 22:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 22:24:08]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-05-23 18:37:59]

mmenke: ping. Thanks.

[mmenke, 2017-05-23 20:49:56]

On 2017/05/23 18:37:59, tbansal1 wrote:
> mmenke: ping. Thanks.

I'm sorry for the delay - foolishly volunteered to give a talk at the last
minute last week, so ended up with a review backlog this week.  I'll get to this
tomorrow.

[mmenke, 2017-05-23 20:49:58]

On 2017/05/23 18:37:59, tbansal1 wrote:
> mmenke: ping. Thanks.

I'm sorry for the delay - foolishly volunteered to give a talk at the last
minute last week, so ended up with a review backlog this week.  I'll get to this
tomorrow.

[tbansal1, 2017-05-23 20:51:39]

On 2017/05/23 20:49:58, mmenke wrote:
> On 2017/05/23 18:37:59, tbansal1 wrote:
> > mmenke: ping. Thanks.
> 
> I'm sorry for the delay - foolishly volunteered to give a talk at the last
> minute last week, so ended up with a review backlog this week.  I'll get to
this
> tomorrow.

np. Thanks for the update.

[mmenke, 2017-05-24 15:49:04]

Sorry again for the delay - 3 days is just way too slow.  Had also thought I'd
be having more to say about it, initially.

https://codereview.chromium.org/2899453002/diff/100001/chrome/browser/io_thre...
File chrome/browser/io_thread.cc (right):

https://codereview.chromium.org/2899453002/diff/100001/chrome/browser/io_thre...
chrome/browser/io_thread.cc:602:
base::MakeUnique<net::nqe::internal::NetworkQualityEstimatorParams>(
Code outside net/ shouldn't be using methods in an "internal" namespace.  Also,
code use outside net/ shouldn't be declared NET_EXPORT_PRIVATE.

[tbansal1, 2017-05-25 07:06:40]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 07:07:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 08:47:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 08:48:00]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-05-25 16:49:23]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 16:49:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-05-25 17:00:58]

tbansal@chromium.org changed reviewers:
+ xunjieli@chromium.org

[tbansal1, 2017-05-25 17:00:58]

mmenke: ptal. 

xunjieli: components/cronet/android/cronet_url_request_context_adapter.cc

Thanks.

[mmenke, 2017-05-25 17:14:09]

On 2017/05/25 17:00:58, tbansal1 wrote:
> mmenke: ptal. 
> 
> xunjieli: components/cronet/android/cronet_url_request_context_adapter.cc
> 
> Thanks.

LGTM (Sorry, meant to LGTM it last time)

[commit-bot: I haz the power, 2017-05-25 17:20:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 17:20:59]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tbansal1, 2017-05-25 17:28:09]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 17:28:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tbansal1, 2017-05-25 17:28:57]

tbansal@chromium.org changed reviewers:
+ rohitrao@chromium.org, ryansturm@chromium.org

[tbansal1, 2017-05-25 17:28:58]

rohitrao: ptal at ios/chrome/browser/ios_chrome_io_thread.mm

ryansturm: //net/nqe. Thanks.

[xunjieli, 2017-05-25 17:56:42]

On 2017/05/25 17:00:58, tbansal1 wrote:
> mmenke: ptal. 
> 
> xunjieli: components/cronet/android/cronet_url_request_context_adapter.cc
> 
> Thanks.

cronet lgtm

[commit-bot: I haz the power, 2017-05-25 18:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 18:58:53]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-05-26 12:46:40]

ios/ lgtm

[RyanSturm, 2017-05-31 18:28:58]

lgtm

[tbansal1, 2017-06-07 21:06:18]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 21:07:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:15:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tbansal1, 2017-06-07 23:18:15]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 23:19:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 01:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 01:13:54]

Dry run: This issue passed the CQ dry run.

[tbansal1, 2017-06-08 04:57:44]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-06-08 04:57:45]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org,
ryansturm@chromium.org, xunjieli@chromium.org, rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2899453002/#ps180001
(title: "Rebased")

[commit-bot: I haz the power, 2017-06-08 04:58:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 05:03:21]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1496897864731930,
"parent_rev": "26c5026c6f179f4e4e98a723d3dd9f1a80e6b38e", "commit_rev":
"4a4305a5f603f83ce7eafad9866565af013815c5"}

[commit-bot: I haz the power, 2017-06-08 05:03:33]

Description was changed from

==========
Pass parsed network quality estimator params when constructing NQE

This CL changes the way how Network Quality Estimator (NQE) is 
constructed. Currently, NQE configuration parameters are passed as
key-value pair by Chrome/Cronet in the NQE's constructor.

This CL requires Chrome/Cronet to parse the config params themselves,
store them in a class, and pass an instance of that class in the 
constructor of NQE.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=638308
==========

to

==========
Pass parsed network quality estimator params when constructing NQE

This CL changes the way how Network Quality Estimator (NQE) is 
constructed. Currently, NQE configuration parameters are passed as
key-value pair by Chrome/Cronet in the NQE's constructor.

This CL requires Chrome/Cronet to parse the config params themselves,
store them in a class, and pass an instance of that class in the 
constructor of NQE.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=638308

Review-Url: https://codereview.chromium.org/2899453002
Cr-Commit-Position: refs/heads/master@{#477896}
Committed:
https://chromium.googlesource.com/chromium/src/+/4a4305a5f603f83ce7eafad98665...
==========

[commit-bot: I haz the power, 2017-06-08 05:03:38]

Committed patchset #6 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/4a4305a5f603f83ce7eafad98665...