Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2899443002: Move code that sets up the environment to run a task to TaskTracker::PerformRunTask(). (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
robliao, gab
CC:
chromium-reviews, gab+watch_chromium.org, robliao+watch_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move code that sets up the environment to run a task to TaskTracker::PerformRunTask(). Move code that sets up the environment to run a task (task runner handles, thread restrictions) from TaskTracker::RunTask() to TaskTracker::PerformRunTask(). That prevents code in the overrides of TaskTracker::PerformRunTask() to run under the thread restrictions set by TaskTracker::RunTask(). BUG=553459 Review-Url: https://codereview.chromium.org/2899443002 Cr-Commit-Position: refs/heads/master@{#473338} Committed: https://chromium.googlesource.com/chromium/src/+/ea326b6451c3b0b6176c65bf517e66a26fc3a543

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -59 lines) Patch
M base/task_scheduler/task_tracker.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M base/task_scheduler/task_tracker.cc View 1 2 chunks +53 lines, -53 lines 0 comments Download
M base/task_scheduler/task_tracker_posix.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/task_scheduler/task_tracker_posix.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-19 18:15:32 UTC) #4
gab
lgtm
3 years, 7 months ago (2017-05-19 20:06:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899443002/20001
3 years, 7 months ago (2017-05-19 20:06:58 UTC) #7
robliao
Quick lgtm.
3 years, 7 months ago (2017-05-19 20:17:36 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 21:44:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ea326b6451c3b0b6176c65bf517e...

Powered by Google App Engine
This is Rietveld 408576698