Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2899433002: cr-buildbucket-dev: define luci.chromium.try bucket (Closed)

Created:
3 years, 7 months ago by nodir
Modified:
3 years, 7 months ago
Reviewers:
dnj, estaab
CC:
chromium-reviews
Target Ref:
refs/heads/infra/config
Project:
chromium
Visibility:
Public.

Description

cr-buildbucket-dev: define luci.chromium.try bucket copy luci.chromium.try bucket definition from cr-buildbucket.cfg to cr-buildbucket-dev.cfg with modifications: - use luci-milo-dev, not prod - use chromium-swarm-dev, not prod - use luci-scheduler-dev, not prod - use pool Chrome - remove allow_milo:1 tag, not needed anymore - allow luci-migration-dev@appspot.gserviceaccount.com to schedule builds (for retries) - exclude buidbot masters from ACLs, we are not going to experiment with them Bug=719734 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2899433002 Committed: https://chromium.googlesource.com/chromium/src/+/93e3be812538b9103dcf749c3f89f8145926fe15

Patch Set 1 #

Patch Set 2 : cr-buildbucket-dev: define luci.chromium.try bucket #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -0 lines) Patch
A cr-buildbucket-dev.cfg View 1 1 chunk +222 lines, -0 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
nodir
PTAL
3 years, 7 months ago (2017-05-19 17:07:25 UTC) #3
estaab
lgtm https://codereview.chromium.org/2899433002/diff/20001/cr-buildbucket-dev.cfg File cr-buildbucket-dev.cfg (right): https://codereview.chromium.org/2899433002/diff/20001/cr-buildbucket-dev.cfg#newcode73 cr-buildbucket-dev.cfg:73: dimensions: "pool:Chrome" why Chrome? everything else is staging ...
3 years, 7 months ago (2017-05-19 17:14:22 UTC) #4
nodir
https://codereview.chromium.org/2899433002/diff/20001/cr-buildbucket-dev.cfg File cr-buildbucket-dev.cfg (right): https://codereview.chromium.org/2899433002/diff/20001/cr-buildbucket-dev.cfg#newcode73 cr-buildbucket-dev.cfg:73: dimensions: "pool:Chrome" On 2017/05/19 17:14:21, estaab wrote: > why ...
3 years, 7 months ago (2017-05-19 23:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899433002/20001
3 years, 7 months ago (2017-05-20 00:00:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/93e3be812538b9103dcf749c3f89f8145926fe15
3 years, 7 months ago (2017-05-20 00:05:53 UTC) #12
Erik Staab (Google)
3 years, 7 months ago (2017-05-20 00:23:09 UTC) #13
Message was sent while issue was closed.
On 2017/05/19 23:59:53, nodir wrote:
> https://codereview.chromium.org/2899433002/diff/20001/cr-buildbucket-dev.cfg
> File cr-buildbucket-dev.cfg (right):
> 
>
https://codereview.chromium.org/2899433002/diff/20001/cr-buildbucket-dev.cfg#...
> cr-buildbucket-dev.cfg:73: dimensions: "pool:Chrome"
> On 2017/05/19 17:14:21, estaab wrote:
> > why Chrome? everything else is staging except this one.
> 
> this is pool "Chrome" on staging server "chromium-swarm-dev.appspot.com". The
> alternative is pool "default" on the same server, but I thought Chrome is more
> appropriate. It probably does not matter, since both are staging and we are
not
> going to run many builds here

That makes sense, thanks for clarifying.

Powered by Google App Engine
This is Rietveld 408576698