Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2899413002:
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm. (Closed)
|
Created:
3 years, 7 months ago by ikilpatrick Modified:
3 years, 6 months ago CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
Review-Url: https://codereview.chromium.org/2899413002
Cr-Commit-Position: refs/heads/master@{#476354}
Committed: https://chromium.googlesource.com/chromium/src/+/639c840bf93e2934fe6b3f564f90060313d5791a
Patch Set 1 #Patch Set 2 : ... #Patch Set 3 : try2 #Patch Set 4 : try3 #
Total comments: 2
Patch Set 5 : new TestExpectations #Patch Set 6 : address comments. #Patch Set 7 : rebase+testexpectations. #
Messages
Total messages: 35 (30 generated)
Description was changed from ========== [LayoutNG] Remove curr_bfc_offset_ [LayoutNG] remove things. BUG= ========== to ========== [LayoutNG] Remove curr_bfc_offset_ [LayoutNG] remove things. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
[LayoutNG] Remove curr_bfc_offset_
[LayoutNG] remove things.
BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========
to
==========
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
==========
ikilpatrick@chromium.org changed reviewers: + cbiesinger@chromium.org, glebl@chromium.org
I think this makes it a bunch clearer whats going on for certain things, I've left some TODO's around for various things which I'll need to investigate separately.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2899413002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2899413002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:91: NGLogicalOffset mutable_offset = {space.BfcOffset().inline_offset, bfc_offset ?
Description was changed from
==========
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
==========
to
==========
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thanks for the review! https://codereview.chromium.org/2899413002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc (right): https://codereview.chromium.org/2899413002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:91: NGLogicalOffset mutable_offset = {space.BfcOffset().inline_offset, On 2017/05/31 04:56:14, Gleb Lanbin wrote: > bfc_offset ? Done.
Description was changed from
==========
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========
to
==========
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
==========
The CQ bit was unchecked by ikilpatrick@chromium.org
The CQ bit was checked by ikilpatrick@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org Link to the patchset: https://codereview.chromium.org/2899413002/#ps120001 (title: "rebase+testexpectations.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1496340465262960,
"parent_rev": "ba20af04ad131e2fc7b8fd4142cffd7461057d5b", "commit_rev":
"639c840bf93e2934fe6b3f564f90060313d5791a"}
Message was sent while issue was closed.
Description was changed from
==========
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
==========
to
==========
[LayoutNG] Removes per-child state from NGBlockLayoutAlgorithm.
Removes curr_bfc_offset_, curr_child_margins_, curr_margin_strut_ in
favour of stack variables.
This clears up the information flow between children, and makes it clear
*which* margin strut, etc is being used for a particular child's
positioning. (E.g. the OOFPositioned child's positioning was difficult
to determine before).
This introduces one regression which I'll investigate separately (static
position is weird with abs-pos legacy children now) - so I've removed the
LayoutNG CQ bot.
BUG=635619
Review-Url: https://codereview.chromium.org/2899413002
Cr-Commit-Position: refs/heads/master@{#476354}
Committed:
https://chromium.googlesource.com/chromium/src/+/639c840bf93e2934fe6b3f564f90...
==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/639c840bf93e2934fe6b3f564f90... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
