Library root fix for win

Library root fix for win

R=jakemac@google.com

Jacob: do we need a fix in jsDebuggingLibraryName too?  could that code be refactored - it looks like it duplicates a lot of logic.
Committed: https://github.com/dart-lang/sdk/commit/5919a12038920d5084116bd101e8013b789765bb

[vsm, 2017-05-24 18:23:17]

Description was changed from

==========
Library root fix for win
==========

to

==========
Library root fix for win

Jacob: do we need a fix in jsDebuggingLibraryName too?  could that code be
refactored - it looks like it duplicates a lot of logic.
==========

[vsm, 2017-05-24 18:23:17]

vsm@google.com changed reviewers:
+ jacobr@google.com, jakemac@google.com

[jakemac, 2017-05-24 18:25:18]

lgtm

https://codereview.chromium.org/2899363002/diff/1/pkg/dev_compiler/lib/src/co...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (left):

https://codereview.chromium.org/2899363002/diff/1/pkg/dev_compiler/lib/src/co...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:6037:
.substring(libraryRoot.length)
Should we change this to use `path.relative` as well, or save that for later?

[vsm, 2017-05-24 19:10:56]

Description was changed from

==========
Library root fix for win

Jacob: do we need a fix in jsDebuggingLibraryName too?  could that code be
refactored - it looks like it duplicates a lot of logic.
==========

to

==========
Library root fix for win

R=jakemac@google.com

Jacob: do we need a fix in jsDebuggingLibraryName too?  could that code be
refactored - it looks like it duplicates a lot of logic.
Committed:
https://github.com/dart-lang/sdk/commit/5919a12038920d5084116bd101e8013b789765bb
==========

[vsm, 2017-05-24 19:10:58]

Committed patchset #1 (id:1) manually as
5919a12038920d5084116bd101e8013b789765bb (presubmit successful).

[Jacob, 2017-05-24 19:23:33]

lgtm

lgtm. 
Please delete jsDebuggingLibraryName as it is dead code.