Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: pkg/dev_compiler/lib/src/compiler/code_generator.dart

Issue 2899363002: Library root fix for win (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/code_generator.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/code_generator.dart b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
index 7df66d29e2a33d9149355743fefa73b20995cab9..07ded75dc49e34019e05d192f1f943a4ff8fba22 100644
--- a/pkg/dev_compiler/lib/src/compiler/code_generator.dart
+++ b/pkg/dev_compiler/lib/src/compiler/code_generator.dart
@@ -6033,7 +6033,8 @@ String jsLibraryName(String libraryRoot, LibraryElement library) {
// E.g., "foo/bar.dart" and "foo$47bar.dart" would collide.
qualifiedPath = uri.pathSegments.skip(1).join(encodedSeparator);
} else if (isWithin(libraryRoot, uri.toFilePath())) {
- qualifiedPath = uri.path
+ qualifiedPath = uri
+ .toFilePath()
.substring(libraryRoot.length)
jakemac 2017/05/24 18:25:17 Should we change this to use `path.relative` as we
.replaceAll(separator, encodedSeparator);
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698