Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2899313003: Revert "Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc." (Closed)

Created:
3 years, 7 months ago by jonross
Modified:
3 years, 7 months ago
Reviewers:
danakj, sadrul
CC:
chromium-reviews, Ian Vollick, jam, dcheng, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, fdoray
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc." The change being reverted has led to failures in mash_browser_tests and mus_browser_tests. These are currently failing on the Mojo FYI bots. We are attempting to bring up more tests on the CQ, but cannot as they are failing with this change. This has led to bugs landing that would have normally been caught by the test suite. Revert "Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc." This reverts commit 4560bffcd8250247bbabe4f3f045ea7fa0d901ba. TBR=sadrul@chromium.org, danakj@chromium.org TEST=mash_browser_tests BUG=725505, 659191 Review-Url: https://codereview.chromium.org/2899313003 Cr-Commit-Position: refs/heads/master@{#474447} Committed: https://chromium.googlesource.com/chromium/src/+/6552fc43089472109de62975dbb91553d7dc19df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -29 lines) Patch
M content/browser/compositor/software_output_device_ozone_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ui/compositor/test/test_suite.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/compositor/test/test_suite.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899313003/1
3 years, 7 months ago (2017-05-24 21:01:04 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 22:22:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6552fc43089472109de62975dbb9...

Powered by Google App Engine
This is Rietveld 408576698