Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2899263002: Update WebScreenOrientationType to have a Last enum member. (Closed)

Created:
3 years, 7 months ago by Uzair
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, mlamouri+watch-blink_chromium.org, jam, mlamouri+watch-screen-orientation_chromium.org, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebScreenOrientationType to have a Last enum member. BUG=None Review-Url: https://codereview.chromium.org/2899263002 Cr-Commit-Position: refs/heads/master@{#474594} Committed: https://chromium.googlesource.com/chromium/src/+/345a41ad87d60ad3214422adb379a373fd0abed0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M content/common/view_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/public/platform/modules/screen_orientation/WebScreenOrientationType.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Uzair
On 2017/05/24 08:48:00, Uzair wrote: > mailto:uzair.jaleel@samsung.com changed reviewers: > + mailto:dcheng@chromium.org Dear Dcheng, PTAL ...
3 years, 7 months ago (2017-05-24 08:48:44 UTC) #3
dcheng
LGTM, thanks for cleaning this up.
3 years, 7 months ago (2017-05-24 18:07:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899263002/1
3 years, 7 months ago (2017-05-25 00:14:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/302724)
3 years, 7 months ago (2017-05-25 03:53:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899263002/1
3 years, 7 months ago (2017-05-25 06:12:56 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 07:04:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/345a41ad87d60ad3214422adb379...

Powered by Google App Engine
This is Rietveld 408576698