Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2899243003: DOM: Fix an incorrect result of getElementsByClassName() in quirks mode. (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM: Fix an incorrect result of getElementsByClassName() in quirks mode. document.getElementsByClassName('\u212a') matched to class="k" and class="K", and did not match to class="K". It should match only to class="K". Element::ClassNames() stores ASCII-lower class string, however getElementsByClassName() applied FoldCase(). Also, this CL removes a unused data member of ClassCollection. BUG=725773, 627682 Review-Url: https://codereview.chromium.org/2899243003 Cr-Commit-Position: refs/heads/master@{#474217} Committed: https://chromium.googlesource.com/chromium/src/+/7b451a789df9be84623fc114a4efe00f5e9dbb5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/dom/nodes/getElementsByClassName-14.htm View 1 chunk +14 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ClassCollection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassCollection.cpp View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
yosin@, would you review this please?
3 years, 7 months ago (2017-05-24 05:07:25 UTC) #3
yosin_UTC9
lgtm This is awesome Unicode feature. Lower case of U+U+212A[1], Kelvin sign, "k" (U+006B) According ...
3 years, 7 months ago (2017-05-24 05:23:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899243003/1
3 years, 7 months ago (2017-05-24 08:18:24 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 08:51:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b451a789df9be84623fc114a4ef...

Powered by Google App Engine
This is Rietveld 408576698