Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2899203002:
[DevTools] Update whats new for m60 (Closed)
|
Created:
3 years, 7 months ago by kayce (google) Modified:
3 years, 6 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Update whats new for m60
BUG=725736
Review-Url: https://codereview.chromium.org/2899203002
Cr-Commit-Position: refs/heads/master@{#476488}
Committed: https://chromium.googlesource.com/chromium/src/+/64a1c51de3474ea2c3a9117fb6051db039af1a76
Patch Set 1 #
Total comments: 1
Patch Set 2 : minify img #Patch Set 3 : formatting #
Total comments: 2
Patch Set 4 : updates #
Total comments: 2
Messages
Total messages: 25 (9 generated)
kayce@google.com changed reviewers: + chenwilliam@chromium.org, pfeldman@chromium.org
overall looks great Kayce! Can you shrink down the image file size with a minifier (e.g. tinypng.com)? https://codereview.chromium.org/2899203002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js (right): https://codereview.chromium.org/2899203002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js:49: link: 'https://developers.google.com/web/updates/2017/05/devtools-release-notes#coverage', I think the anchor needs to be updated: https://developers.google.com/web/updates/2017/05/devtools-release-notes#real...
> Can you shrink down the image file size with a minifier (e.g. tinypng.com)? Whoops, must have uploaded the wrong image. Done > I think the anchor needs to be updated: > https://developers.google.com/web/updates/2017/05/devtools-release-notes#real... Done
lgtm
https://codereview.chromium.org/2899203002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js (right): https://codereview.chromium.org/2899203002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js:31: title: 'Continue to Here keyboard shortcut', Where there is a click involved, it is not technically a shortcut... https://codereview.chromium.org/2899203002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js:42: title: 'New Context Selection menu', That's not worth mentioning, Step int async is though! Bigger part of Paul's presentation was about it and we should reflect it here. Also, would it make sense to link to the youtube video of the I/O talk?
@pavel wdyt > 'Continue to Here keyboard shortcut', > Where there is a click involved, it is not technically a shortcut... It's a shortcut compared to the current workflow, and I don't know what else to call it. How about I just drop "keyboard"? "Continue to Here shortcut" > > https://codereview.chromium.org/2899203002/diff/40001/third_party/WebKit/Sour... > third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js:42: title: > 'New Context Selection menu', > That's not worth mentioning, Step int async is though! Bigger part of Paul's > presentation was about it and we should reflect it here. I can add a "Step into async await" section to the highlights, and work on getting it into the doc today > > Also, would it make sense to link to the youtube video of the I/O talk? How about I put a link to Paul's video at the top of the post?
Doc changes are in flight. Note that there's also a link to the DevTools I/O talk at the top of the doc, now https://codereview.chromium.org/2899203002/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js (right): https://codereview.chromium.org/2899203002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js:40: }, Removed the "context selection menu" item and added "step into async" https://codereview.chromium.org/2899203002/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteText.js:49: link: 'https://developers.google.com/web/updates/2017/05/devtools-release-notes#coverage', I fixed the section anchor in my latest doc changes, so I changed the anchor here again
FYI doc has been updated to include "step into async" https://developers.google.com/web/updates/2017/05/devtools-release-notes
chenwilliam@chromium.org changed reviewers: + dgozman@chromium.org
+dgozman for review since pfeldman is out.
Let's scale the image down to save on bandwidth (e.g. make it similar size as previous one)? Otherwise lgtm.
Description was changed from ========== update whats new for m60 BUG=725736 ========== to ========== [DevTools] Update whats new for m60 BUG=725736 ==========
On 2017/05/25 21:41:02, dgozman wrote: > Let's scale the image down to save on bandwidth (e.g. make it similar size as > previous one)? Otherwise lgtm. Actually, I suggest just keeping the one I've already committed: 1. When I scale down the image and then run it through tinypng, I actually get a larger image than the one I'm using now. I've tried scaling it down with a couple different tools. So the one I've committed is actually the smallest filesize that I can create. 2. Also, the image from last update shows up pixelated on my screen. So we could benefit from a larger image. 3. The filesize of this one is also on par with other stuff we've committed.
I can shave 1.5K off the png using imageoptim. Not a huge win. lgtm, let's get it into beta asap.
The CQ bit was checked by kayce@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from chenwilliam@chromium.org Link to the patchset: https://codereview.chromium.org/2899203002/#ps60001 (title: "updates")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kayce@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1496353478289570,
"parent_rev": "13fb906c913d2886ecec2bb50b42f7d7629711f0", "commit_rev":
"64a1c51de3474ea2c3a9117fb6051db039af1a76"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Update whats new for m60 BUG=725736 ========== to ========== [DevTools] Update whats new for m60 BUG=725736 Review-Url: https://codereview.chromium.org/2899203002 Cr-Commit-Position: refs/heads/master@{#476488} Committed: https://chromium.googlesource.com/chromium/src/+/64a1c51de3474ea2c3a9117fb605... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/64a1c51de3474ea2c3a9117fb605... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
