Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2899193003: Fixed isCurrentNavigationItemPOST for user initiated POSTs. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed isCurrentNavigationItemPOST for user initiated POSTs. CRWWebController allows post requests in loadWithParams:. Those requests will not create _pendingNavigationInfo but will set HasPostData to navigation item. Checking both _pendingNavigationInfo and HasPostData fixes the problem. Tests will be in a separate CL, which implements NavigaitonContext::IsPost(): https://codereview.chromium.org/2903883002/patch/20001/30004 BUG=725241 Review-Url: https://codereview.chromium.org/2899193003 Cr-Commit-Position: refs/heads/master@{#474453} Committed: https://chromium.googlesource.com/chromium/src/+/517153c7d9b005cc6f7495d759a6e26f9f29ca87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-24 20:45:32 UTC) #6
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-24 21:12:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899193003/1
3 years, 7 months ago (2017-05-24 22:31:28 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 22:36:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/517153c7d9b005cc6f7495d759a6...

Powered by Google App Engine
This is Rietveld 408576698