DevTools: Promisify Runtime domain

DevTools: Promisify Runtime domain

BUG=718063
Review-Url: https://codereview.chromium.org/2899163002
Cr-Commit-Position: refs/heads/master@{#474162}
Committed: https://chromium.googlesource.com/chromium/src/+/3bb29f17b7d6f9fdd75ff25bad2aec664b627161

[alph, 2017-05-23 23:19:41]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[alph, 2017-05-23 23:19:42]

Pavel, ptal

[pfeldman, 2017-05-24 00:43:33]

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:573: async
doGetProperties(ownProperties, accessorPropertiesOnly, generatePreview,
callback) {
async function with the callback seems like an anti-pattern.

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:665: async
doSetObjectPropertyValue(result, name) {
async overriden by non-async below.

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:675: return
response[Protocol.error] || response.result.description || undefined;
You should return non-undefined upon error only.

Imagine result == Number(5).

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:281: scriptId:
scriptId,
Use object shortcuts here and everywhere, only for invoke_*.

[pfeldman, 2017-05-24 00:43:37]

lgtm

[alph, 2017-05-24 01:42:58]

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right):

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:573: async
doGetProperties(ownProperties, accessorPropertiesOnly, generatePreview,
callback) {
On 2017/05/24 00:43:32, pfeldman wrote:
> async function with the callback seems like an anti-pattern.

Done.

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:665: async
doSetObjectPropertyValue(result, name) {
On 2017/05/24 00:43:32, pfeldman wrote:
> async overriden by non-async below.

No, they are both async

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:675: return
response[Protocol.error] || response.result.description || undefined;
On 2017/05/24 00:43:32, pfeldman wrote:
> You should return non-undefined upon error only.
> 
> Imagine result == Number(5).

Done.

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2899163002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:281: scriptId:
scriptId,
On 2017/05/24 00:43:32, pfeldman wrote:
> Use object shortcuts here and everywhere, only for invoke_*.

Done.

[alph, 2017-05-24 01:45:12]

The CQ bit was checked by alph@chromium.org

[alph, 2017-05-24 01:45:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2899163002/#ps20001
(title: "addressing comments")

[commit-bot: I haz the power, 2017-05-24 01:46:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-24 04:42:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495590312556150,
"parent_rev": "fbc951ded1697aef6fb274375740d89e66953d18", "commit_rev":
"3bb29f17b7d6f9fdd75ff25bad2aec664b627161"}

[commit-bot: I haz the power, 2017-05-24 04:42:57]

Description was changed from

==========
DevTools: Promisify Runtime domain

BUG=718063
==========

to

==========
DevTools: Promisify Runtime domain

BUG=718063

Review-Url: https://codereview.chromium.org/2899163002
Cr-Commit-Position: refs/heads/master@{#474162}
Committed:
https://chromium.googlesource.com/chromium/src/+/3bb29f17b7d6f9fdd75ff25bad2a...
==========

[commit-bot: I haz the power, 2017-05-24 04:43:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3bb29f17b7d6f9fdd75ff25bad2a...