Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 2899013002: This CL reverts the CL that reverted infobar prompts due to the compile failure (Closed)

Created:
3 years, 7 months ago by ymalik
Modified:
3 years, 7 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

This CL reverts the CL that reverted infobar prompts due to the compile failure on x86/c64 bots. The problem was that VrShellDelegate.java depends on VrFeedbackStatus.java which was only available when enable_vr was set to true. This CL build VrFeedbackStatus as part of chrome_java_sources instead of chrome_vr_java_sources. Original CL: https://codereview.chromium.org/2887383002/ Revert: https://codereview.chromium.org/2896933002/ Revert "Revert "Show an infobar prompting the user to enter feedback when they exit VR"" This reverts commit 007ec6f38ea45bdb1f6adccb088fabc61c34670c. TBR=mthiesse BUG=706438 Review-Url: https://codereview.chromium.org/2899013002 Cr-Commit-Position: refs/heads/master@{#473947} Committed: https://chromium.googlesource.com/chromium/src/+/613b4c77a902de1b1129f77596fb48613fd89ca2

Patch Set 1 #

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2899013002/1
3 years, 7 months ago (2017-05-23 16:58:02 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 17:04:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/613b4c77a902de1b1129f77596fb...

Powered by Google App Engine
This is Rietveld 408576698