Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2898973002:
PlzNavigate: Fix missing console warning. (Closed)
|
Created:
3 years, 7 months ago by arthursonzogni Modified:
3 years, 7 months ago Reviewers:
Mike West CC:
blink-reviews, chromium-reviews, clamy Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPlzNavigate: Fix missing console warning.
When PlzNavigate(--enable-browser-side-navigation) is enabled,
BaseFetchContext::CanRequestInternal([...]) is not used when the
resource to fetch is a frame. This implies that the code part that
check whether or not an url contains new lines in it was not used.
This CL duplicates this part into the FrameLoader.
BUG=723595
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel
Review-Url: https://codereview.chromium.org/2898973002
Cr-Commit-Position: refs/heads/master@{#474250}
Committed: https://chromium.googlesource.com/chromium/src/+/9115376b363cf621a47d8c434c007b9c9e932b57
Patch Set 1 #Patch Set 2 : Nit. #Patch Set 3 : Add http/tests/inspector/service-workers/service-workers-redundant.html again. #
Messages
Total messages: 27 (22 generated)
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== PlzNavigate: Fix missing console warning. When PlzNavigate(--enable-browser-side-navigation) is enabled, BaseFetchContext::CanRequestInternal([...]) is not used when the resource to fetch is a frame. This implies that the code part that check whether or not an url contains new lines in it was not used. This CL duplicates this part into the FrameLoader. BUG=723595 ========== to ========== PlzNavigate: Fix missing console warning. When PlzNavigate(--enable-browser-side-navigation) is enabled, BaseFetchContext::CanRequestInternal([...]) is not used when the resource to fetch is a frame. This implies that the code part that check whether or not an url contains new lines in it was not used. This CL duplicates this part into the FrameLoader. BUG=723595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel ==========
The CQ bit was unchecked by arthursonzogni@chromium.org
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by arthursonzogni@chromium.org
The CQ bit was checked by arthursonzogni@chromium.org to run a CQ dry run
Patchset #3 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
arthursonzogni@chromium.org changed reviewers: + mkwst@chromium.org
Hi Mike, Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thank you! LGTM.
The CQ bit was checked by arthursonzogni@chromium.org
Thanks for the review.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495625197744190,
"parent_rev": "e4706f8ffffd8452011e59e745e952885a74c4ce", "commit_rev":
"9115376b363cf621a47d8c434c007b9c9e932b57"}
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: Fix missing console warning. When PlzNavigate(--enable-browser-side-navigation) is enabled, BaseFetchContext::CanRequestInternal([...]) is not used when the resource to fetch is a frame. This implies that the code part that check whether or not an url contains new lines in it was not used. This CL duplicates this part into the FrameLoader. BUG=723595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel ========== to ========== PlzNavigate: Fix missing console warning. When PlzNavigate(--enable-browser-side-navigation) is enabled, BaseFetchContext::CanRequestInternal([...]) is not used when the resource to fetch is a frame. This implies that the code part that check whether or not an url contains new lines in it was not used. This CL duplicates this part into the FrameLoader. BUG=723595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2898973002 Cr-Commit-Position: refs/heads/master@{#474250} Committed: https://chromium.googlesource.com/chromium/src/+/9115376b363cf621a47d8c434c00... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/9115376b363cf621a47d8c434c00... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
