Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2898953005: [DMC #16] Rename RenderedDocumentMarker to TextMatchMarker (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename RenderedDocumentMarker to TextMatchMarker RenderedDocumentMarker used to be created for all DocumentMarker types. Now it's only created for TextMatchMarkers. Renaming it to TextMatchMarker sets us up to move all of the TextMatch-specific functionality out of DocumentMarker into this class. I eventually want to do this for all the other marker types as well. BUG=707867 Review-Url: https://codereview.chromium.org/2898953005 Cr-Commit-Position: refs/heads/master@{#475070} Committed: https://chromium.googlesource.com/chromium/src/+/802826d9bacfad322a4ec415373d1ed3f317a2a2

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -106 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/editing/markers/RenderedDocumentMarker.h View 1 chunk +0 lines, -85 lines 0 comments Download
A + third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h View 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.cpp View 1 2 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
rlanday
3 years, 7 months ago (2017-05-25 00:25:10 UTC) #2
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-25 05:27:52 UTC) #7
Xiaocheng
lgtm
3 years, 7 months ago (2017-05-25 21:28:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898953005/20001
3 years, 7 months ago (2017-05-26 05:28:17 UTC) #15
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp: While running git apply --index -3 -p1; error: patch ...
3 years, 7 months ago (2017-05-26 07:03:01 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898953005/40001
3 years, 7 months ago (2017-05-26 16:32:43 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 18:35:52 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/802826d9bacfad322a4ec415373d...

Powered by Google App Engine
This is Rietveld 408576698