Remove SupportsWeakPtr inheritance from GLES2Decoder

Remove SupportsWeakPtr inheritance from GLES2Decoder

SupportsWeakPtr's weak pointers are invalidated only after derived class
members are destroyed which may lead to use-after-destroy issues.

This CL removes SupportsWeakPtr from GLES2Decoder and adds a WeakPtrFactory
instance to each of its subclasses.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2898953002
Cr-Commit-Position: refs/heads/master@{#473962}
Committed: https://chromium.googlesource.com/chromium/src/+/0b3fe7fdedf2eb52860ccac16bd8c04822c156b2

[Chandan, 2017-05-23 12:47:42]

Description was changed from

==========
Remove SupportsWeakPtr inheritance from GLES2Decoder

SupportsWeakPtr's weak pointers are invalidated only after derived class
members are destroyed which may lead to use-after-destroy issues.

This CL removes SupportsWeakPtr from GLES2Decoder and adds a WeakPtrFactory
instance to each of its subclasses.

BUG=None
==========

to

==========
Remove SupportsWeakPtr inheritance from GLES2Decoder

SupportsWeakPtr's weak pointers are invalidated only after derived class
members are destroyed which may lead to use-after-destroy issues.

This CL removes SupportsWeakPtr from GLES2Decoder and adds a WeakPtrFactory
instance to each of its subclasses.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Chandan, 2017-05-23 12:49:40]

The CQ bit was checked by c.padhi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 12:49:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 13:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 13:57:05]

Dry run: This issue passed the CQ dry run.

[Chandan, 2017-05-23 14:00:43]

c.padhi@samsung.com changed reviewers:
+ piman@chromium.org, zmo@chromium.org

[Chandan, 2017-05-23 14:00:43]

PTAL. Thank you.

[Zhenyao Mo, 2017-05-23 17:10:38]

lgtm

[Chandan, 2017-05-23 17:30:37]

The CQ bit was checked by c.padhi@samsung.com

[commit-bot: I haz the power, 2017-05-23 17:31:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 17:39:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495560637124600, "parent_rev":
"90510452784fec4a2b9b84d8018606e6d42b4044", "commit_rev":
"0b3fe7fdedf2eb52860ccac16bd8c04822c156b2"}

[commit-bot: I haz the power, 2017-05-23 17:39:23]

Description was changed from

==========
Remove SupportsWeakPtr inheritance from GLES2Decoder

SupportsWeakPtr's weak pointers are invalidated only after derived class
members are destroyed which may lead to use-after-destroy issues.

This CL removes SupportsWeakPtr from GLES2Decoder and adds a WeakPtrFactory
instance to each of its subclasses.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove SupportsWeakPtr inheritance from GLES2Decoder

SupportsWeakPtr's weak pointers are invalidated only after derived class
members are destroyed which may lead to use-after-destroy issues.

This CL removes SupportsWeakPtr from GLES2Decoder and adds a WeakPtrFactory
instance to each of its subclasses.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2898953002
Cr-Commit-Position: refs/heads/master@{#473962}
Committed:
https://chromium.googlesource.com/chromium/src/+/0b3fe7fdedf2eb52860ccac16bd8...
==========

[commit-bot: I haz the power, 2017-05-23 17:39:24]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0b3fe7fdedf2eb52860ccac16bd8...