Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Issue 2898873002: Merges google_input_tools extension into google_xkb extension. The google input tools extension rel… (Closed)

Created:
3 years, 7 months ago by Shu Chen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Merges google_input_tools extension into google_xkb extension. The google input tools extension relative clean up will be in other CL. BUG=709360 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation patch from issue 2894793002 at patchset 1 (http://crrev.com/2894793002#ps1) Review-Url: https://codereview.chromium.org/2898873002 Cr-Commit-Position: refs/heads/master@{#473796} Committed: https://chromium.googlesource.com/chromium/src/+/df82c2f1f609cfe5cead26794eeb85320594c904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+819 lines, -10 lines) Patch
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 chunk +813 lines, -0 lines 0 comments Download
M ui/base/ime/chromeos/extension_ime_util.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Shu Chen
3 years, 7 months ago (2017-05-23 01:54:33 UTC) #2
Azure Wei
lgtm
3 years, 7 months ago (2017-05-23 01:55:41 UTC) #3
wuyingbing
lgtm
3 years, 7 months ago (2017-05-23 03:06:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898873002/1
3 years, 7 months ago (2017-05-23 03:06:47 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 03:11:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df82c2f1f609cfe5cead26794eeb...

Powered by Google App Engine
This is Rietveld 408576698