Allow the PrinterDetector to be constructed with a delegated profile.

Allow the PrinterDetector to be constructed with a delegated profile.

The add printer dialog was crashing in Guest Mode because a
PrinterDetector could not be constructed.  It is okay for
PrinterDetector to be shared between logged in profiles.

BUG=724278
Review-Url: https://codereview.chromium.org/2898833002
Cr-Commit-Position: refs/heads/master@{#473761}
Committed: https://chromium.googlesource.com/chromium/src/+/cb6535121b738ffffecab30176010bb03e5ca447

[skau, 2017-05-22 22:18:01]

The CQ bit was checked by skau@chromium.org to run a CQ dry run

[skau, 2017-05-22 22:18:20]

skau@chromium.org changed reviewers:
+ justincarlson@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:18:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Carlson, 2017-05-22 22:23:53]

lgtm

[skau, 2017-05-22 22:25:17]

skau@chromium.org changed reviewers:
+ derat@chromium.org

[skau, 2017-05-22 22:25:17]

derat@: PTAL as a chromeos/* OWNER

[Daniel Erat, 2017-05-22 22:29:37]

lgtm

https://codereview.chromium.org/2898833002/diff/1/chrome/browser/chromeos/pri...
File chrome/browser/chromeos/printer_detector/printer_detector_factory.h
(right):

https://codereview.chromium.org/2898833002/diff/1/chrome/browser/chromeos/pri...
chrome/browser/chromeos/printer_detector/printer_detector_factory.h:28:
content::BrowserContext* GetBrowserContextToUse(
nit: mind adding a comment above this line to make it easier to see where this
is overridden from? (yes, there's only one base class in this case.) these
styles are common in chromium:

  // BrowserContextKeyedServiceFactory:

or

  // BrowserContextKeyedServiceFactory overrides:

ditto for the overridden methods in the private section.

[commit-bot: I haz the power, 2017-05-22 22:51:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:51:43]

Dry run: This issue passed the CQ dry run.

[skau, 2017-05-22 23:49:00]

The CQ bit was checked by skau@chromium.org

[skau, 2017-05-22 23:49:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincarlson@chromium.org, derat@chromium.org
Link to the patchset: https://codereview.chromium.org/2898833002/#ps20001
(title: "comments")

[skau, 2017-05-22 23:49:12]

https://codereview.chromium.org/2898833002/diff/1/chrome/browser/chromeos/pri...
File chrome/browser/chromeos/printer_detector/printer_detector_factory.h
(right):

https://codereview.chromium.org/2898833002/diff/1/chrome/browser/chromeos/pri...
chrome/browser/chromeos/printer_detector/printer_detector_factory.h:28:
content::BrowserContext* GetBrowserContextToUse(
On 2017/05/22 22:29:37, Daniel Erat wrote:
> nit: mind adding a comment above this line to make it easier to see where this
> is overridden from? (yes, there's only one base class in this case.) these
> styles are common in chromium:
> 
>   // BrowserContextKeyedServiceFactory:
> 
> or
> 
>   // BrowserContextKeyedServiceFactory overrides:
> 
> ditto for the overridden methods in the private section.

Done.

[commit-bot: I haz the power, 2017-05-22 23:49:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 00:30:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495496940131680,
"parent_rev": "7197acdffac9a256fb1eed080469b2f383b97897", "commit_rev":
"cb6535121b738ffffecab30176010bb03e5ca447"}

[commit-bot: I haz the power, 2017-05-23 00:30:20]

Description was changed from

==========
Allow the PrinterDetector to be constructed with a delegated profile.

The add printer dialog was crashing in Guest Mode because a
PrinterDetector could not be constructed.  It is okay for
PrinterDetector to be shared between logged in profiles.

BUG=724278
==========

to

==========
Allow the PrinterDetector to be constructed with a delegated profile.

The add printer dialog was crashing in Guest Mode because a
PrinterDetector could not be constructed.  It is okay for
PrinterDetector to be shared between logged in profiles.

BUG=724278

Review-Url: https://codereview.chromium.org/2898833002
Cr-Commit-Position: refs/heads/master@{#473761}
Committed:
https://chromium.googlesource.com/chromium/src/+/cb6535121b738ffffecab3017601...
==========

[commit-bot: I haz the power, 2017-05-23 00:30:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb6535121b738ffffecab3017601...