Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4879)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2898823002: Add metrics for search engine promo and search widget (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
index 07ac83201c5ef4fe7294920f92a5a915e660d278..04d9593608a022c4195b9c7afc10d3441fb60695 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
@@ -56,6 +56,7 @@ import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.NativePage;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.WindowDelegate;
+import org.chromium.chrome.browser.locale.LocaleManager;
import org.chromium.chrome.browser.ntp.NativePageFactory;
import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.ntp.NewTabPage.FakeboxDelegate;
@@ -2218,6 +2219,8 @@ public class LocationBarLayout extends FrameLayout
setUrlToPageUrl();
}
+ LocaleManager.getInstance().recordLocaleBasedSearchMetrics(true, url, transition);
Ted C 2017/05/22 21:57:02 should this be false?
Yusuf 2017/05/22 22:31:14 Done.
+
if (currentTab != null) currentTab.requestFocus();
// Prevent any upcoming omnibox suggestions from showing. We have to do this after we load

Powered by Google App Engine
This is Rietveld 408576698