Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2898793002: DevTools: disable input event processing while auditing with lighthouse. (Closed)

Created:
3 years, 7 months ago by pfeldman
Modified:
3 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: disable input event processing while auditing with lighthouse. Review-Url: https://codereview.chromium.org/2898793002 Cr-Commit-Position: refs/heads/master@{#474068} Committed: https://chromium.googlesource.com/chromium/src/+/a26cfa5ec070cc7f3da358d398f66ea234d44891

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M content/browser/devtools/protocol/input_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 1 3 chunks +20 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
pfeldman
3 years, 7 months ago (2017-05-22 18:33:44 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2898793002/diff/1/content/browser/devtools/protocol/input_handler.cc File content/browser/devtools/protocol/input_handler.cc (right): https://codereview.chromium.org/2898793002/diff/1/content/browser/devtools/protocol/input_handler.cc#newcode203 content/browser/devtools/protocol/input_handler.cc:203: if (host_ && ignore_input_events_) Drop this. https://codereview.chromium.org/2898793002/diff/1/third_party/WebKit/Source/core/inspector/browser_protocol.json File ...
3 years, 7 months ago (2017-05-22 18:35:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898793002/20001
3 years, 7 months ago (2017-05-22 18:44:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/461417)
3 years, 7 months ago (2017-05-22 22:21:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898793002/20001
3 years, 7 months ago (2017-05-23 18:38:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/391052)
3 years, 7 months ago (2017-05-23 19:29:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898793002/20001
3 years, 7 months ago (2017-05-23 21:19:04 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 21:42:07 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a26cfa5ec070cc7f3da358d398f6...

Powered by Google App Engine
This is Rietveld 408576698